test(release): isolate release-notes fixture env - #762
Merged
Conversation
Release-note fallback fixtures must not inherit CI LLM credentials, which can turn a local fallback assertion into a real network request and timeout. Co-Authored-By: Claude <noreply@anthropic.com>
Exercise the squash-promotion fallback with complete ambient LLM settings and verify that no release-note configuration reaches the node subprocess. Co-Authored-By: Claude <noreply@anthropic.com>
SsuJojo
approved these changes
Sep 1, 2026
SsuJojo
left a comment
SsuJojo
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! Cleanly isolates ambient LLM environment variables in release-notes test fixtures and verifies subprocess leak prevention via the node shim test. Thanks for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RELEASE_NOTES_*configuration from the environment used by release-notes fallback test fixtures.Test plan
CI=true GITHUB_ACTIONS=true RELEASE_NOTES_BASE_URL=http://127.0.0.1:9/v1 RELEASE_NOTES_API_KEY=test-key RELEASE_NOTES_MODEL=test-model RELEASE_NOTES_REQUEST_TIMEOUT_MS=3000 npx vitest run tests/unit/ci/release-notes-script.test.ts --pool=forks --maxWorkers=1 --minWorkers=1 --testTimeout=5000 --hookTimeout=10000npx tsc --noEmitgit diff --checkNotes