Merged
Conversation
Owner
|
Thanks for the fix! This is included in 0.7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greetings,
Currently, certain durations that end up with very small nanoseconds end up malformed such that
from_str(to_str(duration))results in an exception.Specifically:
The reason is that we format a very small number with
:gwhich uses scientific notation once it becomes shorter than:f. We also can't use:fbecause it will results in things like4.00000sWe get the small number because of
I chose rounding nanoseconds because it should be the smallest unit of precision anyway but anything that fixes this is fine.