Skip to content

feat: complete ForgeDesk-parity calculation workflow#18

Merged
ichwars merged 39 commits into
mainfrom
codex/calculation-forgedesk-parity
Jul 15, 2026
Merged

feat: complete ForgeDesk-parity calculation workflow#18
ichwars merged 39 commits into
mainfrom
codex/calculation-forgedesk-parity

Conversation

@ichwars

@ichwars ichwars commented Jul 12, 2026

Copy link
Copy Markdown
Owner

Summary

  • centralize printer and dryer costing in device management
  • add real 3MF analysis, multi-operation costing, templates, revisions, and approval warnings
  • improve calculation settings and overview UX

Verification

  • Backend: 294 relevant tests passed
  • Frontend: 2466 tests passed
  • ESLint and i18n parity passed
  • Production build passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

energy = (
inputs.print_hours_per_run * Decimal(runs) * inputs.printer_power_kw
+ inputs.drying_hours * inputs.dryer_power_kw
) * inputs.electricity_price_per_kwh

P2 Badge Charge selected dryer depreciation, not just power

When a user explicitly selects a dryer, the UI stores dryer_hourly_rate in provenance and device management exposes the derived hourly cost, but the calculation engine only adds dryer electricity here. Any drying operation therefore omits the dryer's depreciation/maintenance hourly cost from both preview and approval, so quotes using paid dryer equipment are systematically under-costed.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread backend/app/services/calculation.py Outdated
Comment thread backend/app/services/calculation.py Outdated
Comment thread backend/app/services/calculation.py Outdated
Comment thread backend/app/schemas/printer.py
Comment thread frontend/src/components/orders/calculation/DeviceAssignmentEditor.tsx Outdated
Comment thread frontend/src/components/orders/CalculationWorkspace.tsx Outdated
Comment thread frontend/src/components/orders/calculation/CalculationSettings.tsx Outdated
Comment thread frontend/src/components/orders/calculation/SourceFileEditor.tsx Outdated
Comment thread frontend/src/components/orders/CalculationWorkspace.tsx
Comment thread backend/app/services/calculation.py Outdated
@ichwars
ichwars merged commit a69d699 into main Jul 15, 2026
30 checks passed
@ichwars
ichwars deleted the codex/calculation-forgedesk-parity branch July 15, 2026 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant