Reduce the maximum number of retries from 99 to 9#416
Merged
icing merged 1 commit intoicing:masterfrom Apr 20, 2026
Merged
Conversation
|
sometimes I need more than 9 retries due to bad DNS synchronizations beetween providers and/or NIC problems ... my 2 cents ;) |
Contributor
Author
|
@pizzi80 There are different types of retries. This PR changes the number of retries that are done immediately if a request to the ACME CA fails. If a certificate renewal operation fails, that operation is also retried, with a delay. This PR does not change that. |
mkauf
force-pushed
the
change_max_retries
branch
from
6b0d2d0 to
16f1e50
Compare
|
thanks for taking time to reply! ... my reply was only to represent a common situation thanks for your work!! |
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Are 99 retries really necessary?
Feel free to decline this PR if you disagree - or use an even lower number if you want (3?).