Raise event#254
Merged
Merged
Conversation
Still need to do converter for Foo?.Invoke And for general case of switching to say FooEvent rather than Foo (unless actually raising an event)
Now need to do special case for RaiseEvent Blah and RaiseEvent Me.Blah
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code and tests used to be tailored based on syntax alone which meant there were lots of false positives and negatives for detecting events. I've changed the code to use the semantic model to inform the conversion, and changed the tests to have valid compiling inputs/outputs.
It generally errs on the side of assuming something isn't an event, which will cause a change in behaviour "for the worse" in some cases that were specifically targeted by the old code. It's hard enough to get the right conversion when all information is available, so I'd rather focus on that, then make very explicit separate handling for cases of incomplete information that are only triggered when the semantic model comes up empty. Those cases will be prioritized based on user requests.