Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous fixes #311

Merged
merged 2 commits into from May 7, 2019

Conversation

Projects
None yet
2 participants
@mrmonday
Copy link
Contributor

commented May 7, 2019

Fixes a couple of issues from previous PRs.

Problem

  • Exception when Nothing is passed as a ByRef parameter
  • Exception when Integer parameter is passed where an enum type is expected

Solution

  • Handle missing case for enum conversions

  • Handle lack of type info for ByRef parameters

  • At least one test covering the code changed

  • All tests pass

@GrahamTheCoder GrahamTheCoder merged commit 24c708b into icsharpcode:master May 7, 2019

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@mrmonday mrmonday deleted the mrmonday:misc-fixes branch May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.