Skip to content

Miscellaneous fixes#311

Merged
GrahamTheCoder merged 2 commits into
icsharpcode:masterfrom
mrmonday:misc-fixes
May 7, 2019
Merged

Miscellaneous fixes#311
GrahamTheCoder merged 2 commits into
icsharpcode:masterfrom
mrmonday:misc-fixes

Conversation

@mrmonday
Copy link
Copy Markdown
Contributor

@mrmonday mrmonday commented May 7, 2019

Fixes a couple of issues from previous PRs.

Problem

  • Exception when Nothing is passed as a ByRef parameter
  • Exception when Integer parameter is passed where an enum type is expected

Solution

  • Handle missing case for enum conversions

  • Handle lack of type info for ByRef parameters

  • At least one test covering the code changed

  • All tests pass

@GrahamTheCoder GrahamTheCoder merged commit 24c708b into icsharpcode:master May 7, 2019
@mrmonday mrmonday deleted the misc-fixes branch May 7, 2019 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants