Skip to content

Trim whitespace from event source identifiers. Fixes #701#702

Merged
GrahamTheCoder merged 1 commit intoicsharpcode:masterfrom
jconnop:Issue701_MultiLineHandles
Feb 7, 2021
Merged

Trim whitespace from event source identifiers. Fixes #701#702
GrahamTheCoder merged 1 commit intoicsharpcode:masterfrom
jconnop:Issue701_MultiLineHandles

Conversation

@jconnop
Copy link
Copy Markdown
Contributor

@jconnop jconnop commented Feb 4, 2021

Link to issue(s) this covers

Problem

#701

Solution

  • When 'Handles' identifier is on new line, it gets prefixed with a bunch of whitespace. i.e.
                                          Button2
  • So after getting this identifier from syntax tree / library calls, trim it before escaping and using.
  • At least one test covering the code changed

@jconnop jconnop marked this pull request as ready for review February 4, 2021 23:14
@GrahamTheCoder
Copy link
Copy Markdown
Member

Wow. I've seen some weird stuff from VB before. But parsing whitespace on the identifier sounds like a pretty serious library bug. Thanks for the workaround. I'll try to have a proper look soon and see if this needs raising in dotnet roslyn repo

@GrahamTheCoder GrahamTheCoder merged commit 35aa2ce into icsharpcode:master Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants