Skip to content

636/onboard repeated popup#649

Merged
EightBitByte merged 8 commits intodevfrom
636/onboard-repeated-popup
Apr 14, 2026
Merged

636/onboard repeated popup#649
EightBitByte merged 8 commits intodevfrom
636/onboard-repeated-popup

Conversation

@MihaiZecheru
Copy link
Copy Markdown
Contributor

Summary

Prevent repeated popups after the user initially closes the onboarding dialog by saving a flag value to localStorage.

Closes #636

Used localstorage to save that it's been previously closed
@MihaiZecheru MihaiZecheru changed the base branch from main to dev February 25, 2026 19:25
Combine DB and local storage onboarding checks into single hasOnboarded variable.
@MihaiZecheru MihaiZecheru temporarily deployed to staging-649 February 26, 2026 00:34 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to staging-649 February 26, 2026 00:35 Inactive
@MihaiZecheru MihaiZecheru temporarily deployed to staging-649 February 26, 2026 00:38 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to staging-649 February 26, 2026 00:39 Inactive
Copy link
Copy Markdown
Collaborator

@EightBitByte EightBitByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick refactor. Great work though!

@MihaiZecheru MihaiZecheru temporarily deployed to staging-649 March 5, 2026 01:49 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to staging-649 March 5, 2026 01:50 Inactive
@MihaiZecheru MihaiZecheru temporarily deployed to staging-649 March 5, 2026 05:44 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to staging-649 March 5, 2026 05:45 Inactive
Copy link
Copy Markdown
Collaborator

@LexTruong LexTruong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Chris, thanks for switching to using the userStore. However, the onboarding dialog still seems to be popping up when switching away and back tabs. Also, I need to click 2 times to close the dialog.

@MihaiZecheru MihaiZecheru temporarily deployed to staging-649 March 25, 2026 05:40 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to staging-649 March 25, 2026 05:40 Inactive
Copy link
Copy Markdown
Collaborator

@EightBitByte EightBitByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one change! Remember not to make sweeping changes on a page without consulting a lead first. The homepage should remain as is, not be returned to the side layout for the homepage.

@MihaiZecheru MihaiZecheru temporarily deployed to staging-649 April 8, 2026 02:40 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to staging-649 April 8, 2026 02:40 Inactive
@MihaiZecheru MihaiZecheru temporarily deployed to staging-649 April 14, 2026 00:08 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to staging-649 April 14, 2026 00:09 Inactive
Copy link
Copy Markdown
Collaborator

@EightBitByte EightBitByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 👍

@EightBitByte EightBitByte requested a review from LexTruong April 14, 2026 00:11
@EightBitByte EightBitByte dismissed LexTruong’s stale review April 14, 2026 00:12

Review completed.

@EightBitByte EightBitByte merged commit f3a64f8 into dev Apr 14, 2026
2 of 3 checks passed
@EightBitByte EightBitByte deleted the 636/onboard-repeated-popup branch April 14, 2026 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Onboarding Popup repeatedly triggers

3 participants