ci: align Linux prepublish gate budgets - #284
Conversation
📝 WalkthroughWalkthroughThe CI and npm publish workflows increase the prepublish release gate timeout from 15 to 18 minutes. Workflow tests now parse named jobs and validate Ubuntu, macOS, and publish timeout values separately. ChangesCI release gate
Estimated code review effort: 2 (Simple) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/test_workflows.py`:
- Around line 107-112: Update the test around the ubuntu_job and macos_job
extraction to isolate the exact test-and-prepublish and
test-and-prepublish-macos job blocks before asserting step timeouts. Parse the
jobs mapping or use bounded extraction between named job markers so matching
text from unrelated jobs cannot satisfy the assertions.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: a157cc0c-4412-4b52-a9a9-5b2b1e9dc858
📒 Files selected for processing (1)
tests/test_workflows.py
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/test_workflows.py`:
- Line 98: Extend the publish-job assertion in the relevant test to match the
exact release_smoke.py step sequence and its 5-minute timeout, in addition to
the existing prepublish_check.py assertion. Keep the assertion anchored to
publish_job so changes to the npm publish smoke limit fail the test.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: a78a670a-c347-4808-8dcf-b677cbcb31e0
📒 Files selected for processing (2)
.github/workflows/npm-publish.ymltests/test_workflows.py
Summary
Evidence
Verification
git diff --check origin/main...HEADpassed