feat(em511): Change struct of driver - #43
Merged
Merged
Conversation
Dexter9532
force-pushed
the
new_struct_v2
branch
from
October 30, 2025 12:32
5f5dd85 to
a1467c8
Compare
Dexter9532
marked this pull request as ready for review
October 30, 2025 12:33
mirzak
requested changes
Oct 30, 2025
mirzak
left a comment
mirzak
left a comment
Contributor
There was a problem hiding this comment.
Nice, some minor things.
Your commit body message has a typo in it,
Code was the same in many palces so did this to make it be cleaner
Dexter9532
force-pushed
the
new_struct_v2
branch
2 times, most recently
from
October 30, 2025 13:45
541cd74 to
0a04839
Compare
Dexter9532
force-pushed
the
new_struct_v2
branch
from
October 30, 2025 13:47
0a04839 to
5efaf06
Compare
Code was the same in many places so did this to make it be cleaner Co-authored-by: Mirza Krak <mirza@mkrak.org> Signed-off-by: Bobo Bäck Engström <bobo@id8-engineering.io>
mirzak
previously approved these changes
Oct 30, 2025
MiladMakdesi
left a comment
MiladMakdesi
left a comment
Contributor
There was a problem hiding this comment.
2 typos, rename tests to appropriate No. order.
Signed-off-by: Mirza Krak <mirza@mkrak.org>
mirzak
approved these changes
Oct 31, 2025
Contributor
|
@MiladMakdesi, you need to approve for us to be able to merge it. |
MiladMakdesi
approved these changes
Oct 31, 2025
This was referenced Oct 31, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code was the same in many places so did this to make it be cleaner