peacock does not support hit file brace expression

[dzheng26]

I just found out that peacock does not support hit file brace expression. You can try any file with brace expression to show the error. For example test/tests/coord_type/coord_type_rz_general.i

In the generated tmp files peacock_run_mesh_tmp.i and peacock_run_exe_tmp_coord_type_rz_general.i, the brace expression variable definitions are removed. However all the comment lines are kept. Are the brace expression variable definitions are removed intentionally or this is a bug? If we can keep all the comment lines, I guess it should be easy also to keep the variable definitions.

Original file

# Tests using different coordinate systems in different blocks:
#   block1: XYZ translated by (0,-1,0)
#   block2: RZ with origin=(0,0,0) and direction=(0,1,0)
#   block3: RZ with origin=(0,0,1) and direction=(1,0,0)
#   block4: RZ with origin=(-1,-2,-3) and direction=(1,1,0)
#
# A transient heat conduction equation is solved with uniform properties.
# The same power is applied to each block via a uniform heat flux boundary
# condition on the outer cylindrical surface (top surface for block1).
# Conservation is checked for each via post-processors.
# Blocks block2, block3, and block4 should have identical solutions.

rho = 1000.0
cp = 500.0
k = 15.0

length = 1.5
radius = 0.5

perimeter = ${fparse 2 * pi * radius}

nz = 10
nr = 5

power = 1e3
heat_flux = ${fparse power / (perimeter * length)}

[Mesh]
  # block1
  [genmesh1]
......

The tmp file

# Tests using different coordinate systems in different blocks:
# block1: XYZ translated by (0,-1,0)
# block2: RZ with origin=(0,0,0) and direction=(0,1,0)
# block3: RZ with origin=(0,0,1) and direction=(1,0,0)
# block4: RZ with origin=(-1,-2,-3) and direction=(1,1,0)
#
# A transient heat conduction equation is solved with uniform properties.
# The same power is applied to each block via a uniform heat flux boundary
# condition on the outer cylindrical surface (top surface for block1).
# Conservation is checked for each via post-processors.
# Blocks block2, block3, and block4 should have identical solutions.
[Mesh]
  # block1
  # block2
  # block3
  # block4
  coord_block = 'block1 block2 block3 block4'
  coord_type = 'XYZ RZ RZ RZ'
  rz_coord_blocks = 'block2 block3 block4'
  rz_coord_origins = '0 0 0
                      0 0 1
                      -1 -2 -3'
  rz_coord_directions = '0 1 0
                         1 0 0
                         1 1 0'
  [genmesh1]
......

[GiudGiud]

Hello

Are you sure the expressions set by ${} have not been automatically replaced with their values?
those tmp files are likely generated after processing the input

Guillaume

[dzheng26]

I'm sure that is the case. After activate the environment and compile the test app in the moose test folder, I used ../gui/peacock -i tests/coord_type/coord_type_rz_general.i. Then I got the warning and error messages

WARNING
 Error producing mesh: '/femshare/azure/femdeploy/Users/uf00788/fem/moose/test/moose_test-opt -i /femshare/azure/femdeploy/Users/uf00788/fem/moose/test/tests/coord_type/peacock_run_mesh_tmp.i --mesh-only /femshare/azure/femdeploy/Users/uf00788/fem/moose/test/tests/coord_type/peacock_run_mesh_tmp_coord_type_rz_general.e --allow-test-objects' exited with non zero status 1.

Please make sure your application is built and able to execute the given arguments.
Working dir: /femshare/azure/femdeploy/Users/uf00788/fem/moose/test/tests/coord_type
Output: 

*** ERROR ***
/femshare/azure/femdeploy/Users/uf00788/fem/moose/test/tests/coord_type/peacock_run_mesh_tmp.i:29.5: no variable 'nz' found for substitution expression
/femshare/azure/femdeploy/Users/uf00788/fem/moose/test/tests/coord_type/peacock_run_mesh_tmp.i:30.5: no variable 'nr' found for substitution expression
/femshare/azure/femdeploy/Users/uf00788/fem/moose/test/tests/coord_type/peacock_run_mesh_tmp.i:32.5: no variable 'length' found for substitution expression
/femshare/azure/femdeploy/Users/uf00788/fem/moose/test/tests/coord_type/peacock_run_mesh_tmp.i:34.5: 
    no variable 'radius' found for use in function parser expression
/femshare/azure/femdeploy/Users/uf00788/fem/moose/test/tests/coord_type/peacock_run_mesh_tmp.i:58.5: no variable 'nr' found for substitution expression
/femshare/azure/femdeploy/Users/uf00788/fem/moose/test/tests/coord_type/peacock_run_mesh_tmp.i:59.5: no variable 'nz' found for substitution expression
/femshare/azure/femdeploy/Users/uf00788/fem/moose/test/tests/coord_type/peacock_run_mesh_tmp.i:61.5: no variable 'radius' found for substitution expression
/femshare/azure/femdeploy/Users/uf00788/fem/moose/test/tests/coord_type/peacock_run_mesh_tmp.i:63.5: no variable 'length' found for substitution expression
/femshare/azure/femdeploy/Users/uf00788/fem/moose/test/tests/coord_type/peacock_run_mesh_tmp.i:87.5: no variable 'nz' found for substitution expression
/femshare/azure/femdeploy/Users/uf00788/fem/moose/test/tests/coord_type/peacock_run_mesh_tmp.i:88.5: no variable 'nr' found for substitution expression
/femshare/azure/femdeploy/Users/uf00788/fem/moose/test/tests/coord_type/peacock_run_mesh_tmp.i:90.5: no variable 'length' found for substitution expression
/femshare/azure/femdeploy/Users/uf00788/fem/moose/test/tests/coord_type/peacock_run_mesh_tmp.i:92.5: no variable 'radius' found for substitution expression
/femshare/azure/femdeploy/Users/uf00788/fem/moose/test/tests/coord_type/peacock_run_mesh_tmp.i:122.5: no variable 'nz' found for substitution expression
/femshare/azure/femdeploy/Users/uf00788/fem/moose/test/tests/coord_type/peacock_run_mesh_tmp.i:123.5: no variable 'nr' found for substitution expression
/femshare/azure/femdeploy/Users/uf00788/fem/moose/test/tests/coord_type/peacock_run_mesh_tmp.i:125.5: no variable 'length' found for substitution expression
/femshare/azure/femdeploy/Users/uf00788/fem/moose/test/tests/coord_type/peacock_run_mesh_tmp.i:127.5: no variable 'radius' found for substitution expression
/femshare/azure/femdeploy/Users/uf00788/fem/moose/test/tests/coord_type/peacock_run_mesh_tmp.i:180.5: no variable 'power' found for substitution expression
/femshare/azure/femdeploy/Users/uf00788/fem/moose/test/tests/coord_type/peacock_run_mesh_tmp.i:200.5: 
    no variable 'cp' found for use in function parser expression
/femshare/azure/femdeploy/Users/uf00788/fem/moose/test/tests/coord_type/peacock_run_mesh_tmp.i:200.5: 
    no variable 'k' found for use in function parser expression
/femshare/azure/femdeploy/Users/uf00788/fem/moose/test/tests/coord_type/peacock_run_mesh_tmp.i:200.5: 
    no variable 'rho' found for use in function parser expression
/femshare/azure/femdeploy/Users/uf00788/fem/moose/test/tests/coord_type/peacock_run_mesh_tmp.i:210.5: 
    no variable 'cp' found for use in function parser expression
/femshare/azure/femdeploy/Users/uf00788/fem/moose/test/tests/coord_type/peacock_run_mesh_tmp.i:210.5: 
    no variable 'heat_flux' found for use in function parser expression
/femshare/azure/femdeploy/Users/uf00788/fem/moose/test/tests/coord_type/peacock_run_mesh_tmp.i:210.5: 
    no variable 'rho' found for use in function parser expression
/femshare/azure/femdeploy/Users/uf00788/fem/moose/test/tests/coord_type/peacock_run_mesh_tmp.i:233.5: no variable 'rho' found for substitution expression
/femshare/azure/femdeploy/Users/uf00788/fem/moose/test/tests/coord_type/peacock_run_mesh_tmp.i:233.5: no variable 'cp' found for substitution expression
/femshare/azure/femdeploy/Users/uf00788/fem/moose/test/tests/coord_type/peacock_run_mesh_tmp.i:233.5: no variable 'perimeter' found for substitution expression
/femshare/azure/femdeploy/Users/uf00788/fem/moose/test/tests/coord_type/peacock_run_mesh_tmp.i:257.5: no variable 'rho' found for substitution expression
/femshare/azure/femdeploy/Users/uf00788/fem/moose/test/tests/coord_type/peacock_run_mesh_tmp.i:257.5: no variable 'cp' found for substitution expression
/femshare/azure/femdeploy/Users/uf00788/fem/moose/test/tests/coord_type/peacock_run_mesh_tmp.i:281.5: no variable 'rho' found for substitution expression
/femshare/azure/femdeploy/Users/uf00788/fem/moose/test/tests/coord_type/peacock_run_mesh_tmp.i:281.5: no variable 'cp' found for substitution expression
/femshare/azure/femdeploy/Users/uf00788/fem/moose/test/tests/coord_type/peacock_run_mesh_tmp.i:305.5: no variable 'rho' found for substitution expression
/femshare/azure/femdeploy/Users/uf00788/fem/moose/test/tests/coord_type/peacock_run_mesh_tmp.i:305.5: no variable 'cp' found for substitution expression

I cannot exam the about tmp file since it was removed. Peacock window was shown but no mesh was shown in the window.

When I tried to run it, I get the same warning and error messages

In tmp file peacock_run_exe_tmp_coord_type_rz_general.i, ${nc}, ${nr}, ${length} etc are still there while the definitions for them are gone.

# Tests using different coordinate systems in different blocks:
# block1: XYZ translated by (0,-1,0)
# block2: RZ with origin=(0,0,0) and direction=(0,1,0)
# block3: RZ with origin=(0,0,1) and direction=(1,0,0)
# block4: RZ with origin=(-1,-2,-3) and direction=(1,1,0)
#
# A transient heat conduction equation is solved with uniform properties.
# The same power is applied to each block via a uniform heat flux boundary
# condition on the outer cylindrical surface (top surface for block1).
# Conservation is checked for each via post-processors.
# Blocks block2, block3, and block4 should have identical solutions.
[Mesh]
  # block1
  # block2
  # block3
  # block4
  coord_block = 'block1 block2 block3 block4'
  coord_type = 'XYZ RZ RZ RZ'
  rz_coord_blocks = 'block2 block3 block4'
  rz_coord_origins = '0 0 0
                      0 0 1
                      -1 -2 -3'
  rz_coord_directions = '0 1 0
                         1 0 0
                         1 1 0'
  [genmesh1]
    type = GeneratedMeshGenerator
    dim = 2
    nx = ${nz}
    ny = ${nr}
    xmin = 0.0
    xmax = ${length}
    ymin = -1.0
    ymax = '${fparse -1.0 + radius}'
    boundary_id_offset = 10
  []
  [renumberblock1]
    type = RenameBlockGenerator
    input = genmesh1
    old_block = '0'
    new_block = '1'
  []
......

[GiudGiud]

@permcody @cticenhour thoughts? Is this a known issue with peacock or did it used to be supported?

[cticenhour]

I am not aware that this was an issue previously. How is HIT integrated in Peacock? It makes me think that it has something to do with the WASP transition, but I honestly have no clue.

You might need to workaround this by find-and-replacing these quantities yourself in the input.

[permcody]

I don't believe that peacock has ever supported this. HIT brace expression was added long after we quit active development on Peacock. I don't know what it would take to fix it, but it's probably not the highest priority. I would suggest a work-around for now. You might also consider using "Workbench" from ORNL, which is the supported GUI for MOOSE.

[dzheng26]

Thanks for your replies and the clarification. I will try Workbench to see how it works.