Skip to content

add check for enrollment status when determining evidence state#6006

Merged
jacobkagon merged 1 commit intotrunkfrom
CU_868h8t352_check_active_enrollment_and_rop
Jan 29, 2026
Merged

add check for enrollment status when determining evidence state#6006
jacobkagon merged 1 commit intotrunkfrom
CU_868h8t352_check_active_enrollment_and_rop

Conversation

@jacobkagon
Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The title follows our guidelines
  • Tests for the changes have been added (for bug fixes/features), and they use let helpers and before blocks.
  • For all UI changes, there is Cucumber coverage.
  • Any endpoint touched in the PR has an appropriate Pundit policy. For open endpoints, the reasoning is documented in the PR and code.
  • Any endpoint modified in the PR only responds to the expected MIME types.
  • For all scripts or rake tasks, how to run them is documented in both the PR and the code.
  • There are no inline styles added.
  • There is no inline JavaScript added.
  • There is no hard-coded text added/updated in helpers/views/JavaScript. New/updated translation strings do not include markup/styles unless there is supporting documentation.
  • Code does not use .html_safe.
  • All images added/updated have alt text.
  • Does not bypass RuboCop rules in any way.

PR Type

What kind of change does this PR introduce?:

  • Bugfix
  • Feature (requires Feature flag)
  • Data fix, Migration, or Report (inert code, no impact until run)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Dependency updates (e.g., add a new gem or update to a version)
  • Release (Prepares code for a release, e.g., version bumps, changelog updates, tagging, deployment scripts)

What is the ticket # detailing the issue?

Ticket: https://app.clickup.com/t/868h8t352

A brief description of the changes:

Current behavior: When calling the hub for an evidence that is in outstanding and the family does not have active enrollments, the outstanding status is being copied over

New behavior: Factor in enrollment status when checking whether to copy the previous evidence state

Feature Flag

For all new feature development, a feature flag is required to control the exposure of the feature to our end users. A feature flag needs a corresponding environment variable to initialize the state of the flag. Please share the name of the environment variable below that would enable/disable the feature and indicate which client(s) it applies to.

Variable name:

  • DC
  • ME

Additional Context

Include any additional context that may be relevant to the peer review process.

@jacobkagon jacobkagon enabled auto-merge (squash) January 28, 2026 23:34
Copy link
Copy Markdown
Contributor

@ATBull81 ATBull81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 moves check up sooner in the process, lgtm

Copy link
Copy Markdown
Contributor

@TristanB17 TristanB17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solid refactor, lgtm

@jacobkagon jacobkagon merged commit a19de19 into trunk Jan 29, 2026
772 of 801 checks passed
@jacobkagon jacobkagon deleted the CU_868h8t352_check_active_enrollment_and_rop branch January 29, 2026 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants