Skip to content

update aca_entites to include new override rule#6041

Merged
ymhari merged 1 commit intotrunkfrom
clickup_868ed4c8x
Feb 17, 2026
Merged

update aca_entites to include new override rule#6041
ymhari merged 1 commit intotrunkfrom
clickup_868ed4c8x

Conversation

@ymhari
Copy link
Copy Markdown
Contributor

@ymhari ymhari commented Feb 17, 2026

PR Checklist

Please check if your PR fulfills the following requirements:

  • The title follows our guidelines
  • Tests for the changes have been added (for bug fixes/features), and they use let helpers and before blocks.
  • For all UI changes, there is Cucumber coverage.
  • Any endpoint touched in the PR has an appropriate Pundit policy. For open endpoints, the reasoning is documented in the PR and code.
  • Any endpoint modified in the PR only responds to the expected MIME types.
  • For all scripts or rake tasks, how to run them is documented in both the PR and the code.
  • There are no inline styles added.
  • There is no inline JavaScript added.
  • There is no hard-coded text added/updated in helpers/views/JavaScript. New/updated translation strings do not include markup/styles unless there is supporting documentation.
  • Code does not use .html_safe.
  • All images added/updated have alt text.
  • Does not bypass RuboCop rules in any way.

PR Type

What kind of change does this PR introduce?:

  • Bugfix
  • Feature (requires Feature flag)
  • Data fix, Migration, or Report (inert code, no impact until run)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Dependency updates (e.g., add a new gem or update to a version)
  • Release (Prepares code for a release, e.g., version bumps, changelog updates, tagging, deployment scripts)

What is the ticket # detailing the issue?

Ticket: https://app.clickup.com/t/868ed4c8x

A brief description of the changes:

Current behavior:

New behavior:

Feature Flag

For all new feature development, a feature flag is required to control the exposure of the feature to our end users. A feature flag needs a corresponding environment variable to initialize the state of the flag. Please share the name of the environment variable below that would enable/disable the feature and indicate which client(s) it applies to.

Variable name:

  • DC
  • ME

Additional Context

Include any additional context that may be relevant to the peer review process.

@ymhari ymhari requested a review from a team as a code owner February 17, 2026 20:03
@ymhari ymhari added the chore *️⃣ Some non-functional task that won't appear in release notes label Feb 17, 2026
@ymhari ymhari enabled auto-merge (squash) February 17, 2026 20:04
Copy link
Copy Markdown
Contributor

@jacobkagon jacobkagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ymhari ymhari merged commit 8636866 into trunk Feb 17, 2026
269 of 277 checks passed
@ymhari ymhari deleted the clickup_868ed4c8x branch February 17, 2026 20:27
vFos2016 pushed a commit that referenced this pull request Mar 26, 2026
* update aca_entites to include new override rule (#6041)

* check domain for validation when saving tax info and other questions (#6038)

* add logic to detect if step-specific error is present and drive banner based on that

* remove unused helper method

* restore unused method

* comment update

* remove binding and fix spacing

---------

Co-authored-by: Jacob Kagon <69021620+jacobkagon@users.noreply.github.com>

* adjustments for part 1 accessibility remediation findings (#6084)

* adds fixes for part 1 accessibility findings

* cleans up for consistency

* remove fade from select modals due to inconsistent behavior

* missed fade

* remove fade from session expiration warning

---------

Co-authored-by: Alec Turnbull <alecturnbull81@gmail.com>

* refactor edit SEP form to show selected option (#6096)

* refactor build_fieldset_choices and build_input_hash

* lint fix

* add devise to bundler audit ignore (#6098)

---------

Co-authored-by: haridhar yamjala <hariym471@gmail.com>
Co-authored-by: Charlie Parker <charlie.parker@ideacrew.com>
Co-authored-by: Jacob Kagon <69021620+jacobkagon@users.noreply.github.com>
Co-authored-by: Tristan <33517218+TristanB17@users.noreply.github.com>
Co-authored-by: Alec Turnbull <alecturnbull81@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore *️⃣ Some non-functional task that won't appear in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants