Skip to content

update county datafix#6087

Merged
jacobkagon merged 4 commits intotrunkfrom
868hu0b4q_update_county_datafix
Mar 16, 2026
Merged

update county datafix#6087
jacobkagon merged 4 commits intotrunkfrom
868hu0b4q_update_county_datafix

Conversation

@ATBull81
Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The title follows our guidelines
  • Tests for the changes have been added (for bug fixes/features), and they use let helpers and before blocks.
  • For all UI changes, there is Cucumber coverage.
  • Any endpoint touched in the PR has an appropriate Pundit policy. For open endpoints, the reasoning is documented in the PR and code.
  • Any endpoint modified in the PR only responds to the expected MIME types.
  • For all scripts or rake tasks, how to run them is documented in both the PR and the code.
  • There are no inline styles added.
  • There is no inline JavaScript added.
  • There is no hard-coded text added/updated in helpers/views/JavaScript. New/updated translation strings do not include markup/styles unless there is supporting documentation.
  • Code does not use .html_safe.
  • All images added/updated have alt text.
  • Does not bypass RuboCop rules in any way.

PR Type

What kind of change does this PR introduce?:

  • Bugfix
  • Feature (requires Feature flag)
  • Data fix, Migration, or Report (inert code, no impact until run)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Dependency updates (e.g., add a new gem or update to a version)
  • Release (Prepares code for a release, e.g., version bumps, changelog updates, tagging, deployment scripts)

What is the ticket # detailing the issue?

Ticket: https://app.clickup.com/t/868hu0b4q

A brief description of the changes:

Current behavior: Script only fixed cases where the address's county was "Please provide a zip code". There were 69 more cases found with nil as county.

New behavior: Script fixes both "Please provide a zip code" and nil counties.

Feature Flag

For all new feature development, a feature flag is required to control the exposure of the feature to our end users. A feature flag needs a corresponding environment variable to initialize the state of the flag. Please share the name of the environment variable below that would enable/disable the feature and indicate which client(s) it applies to.

Variable name:

  • DC
  • ME

Additional Context

Include any additional context that may be relevant to the peer review process.

Copy link
Copy Markdown
Contributor

@TristanB17 TristanB17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm -> updates missing county data fix to include nil counties

@jacobkagon jacobkagon changed the title 868hu0b4q update county datafix update county datafix Mar 16, 2026
Copy link
Copy Markdown
Contributor

@jacobkagon jacobkagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jacobkagon jacobkagon enabled auto-merge (squash) March 16, 2026 17:27
@jacobkagon jacobkagon merged commit 890fe5d into trunk Mar 16, 2026
271 of 276 checks passed
@jacobkagon jacobkagon deleted the 868hu0b4q_update_county_datafix branch March 16, 2026 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants