Fix schema serialization crash on older EnergyPlus versions#21
Merged
samuelduchesne merged 1 commit intomainfrom Feb 28, 2026
Merged
Fix schema serialization crash on older EnergyPlus versions#21samuelduchesne merged 1 commit intomainfrom
samuelduchesne merged 1 commit intomainfrom
Conversation
Older epJSON schemas have boolean values for min/max bounds (e.g. `"minimum": true`) which cannot be converted to float. Guard the bound extraction with isinstance checks to skip non-numeric values. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
samuelduchesne
force-pushed
the
feature/bold-bose
branch
from
1536a20 to
2f36b24
Compare
samuelduchesne
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
serialize_for_monacocrash on EnergyPlus v8.9-v9.5 where older epJSON schemas use boolean values for min/max bounds (e.g."minimum": true) instead of numeric values, causingfloat('True')to failTest plan
serialize_for_monacosucceeds for all 7 previously-failing versions (v8.9.0, v9.0.1, v9.1.0, v9.2.0, v9.3.0, v9.4.0, v9.5.0)🤖 Generated with Claude Code