Skip to content

Fix schema serialization crash on older EnergyPlus versions #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samuelduchesne merged 1 commit into from
Feb 28, 2026
Merged

Fix schema serialization crash on older EnergyPlus versions #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 23 additions & 5 deletions scripts/schema_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,22 +179,40 @@ def _build_doc_field(
autosizable, autocalculatable = _detect_auto_flags(field_schema)
idd_type = _resolve_idd_type(field_schema)

# Bounds
# Bounds -- older epJSON schemas (v8.9-v9.5) use boolean values for
# min/max (e.g. "minimum": true) instead of numeric bounds. The
# isinstance guards skip these so they don't break float() conversion.
minimum_val = ""
minimum_exclusive = False
maximum_val = ""
maximum_exclusive = False

if "exclusiveMinimum" in field_schema:
if (
"exclusiveMinimum" in field_schema
and isinstance(field_schema["exclusiveMinimum"], (int, float))
and not isinstance(field_schema["exclusiveMinimum"], bool)
):
minimum_val = str(field_schema["exclusiveMinimum"])
minimum_exclusive = True
elif "minimum" in field_schema:
elif (
"minimum" in field_schema
and isinstance(field_schema["minimum"], (int, float))
and not isinstance(field_schema["minimum"], bool)
):
minimum_val = str(field_schema["minimum"])

if "exclusiveMaximum" in field_schema:
if (
"exclusiveMaximum" in field_schema
and isinstance(field_schema["exclusiveMaximum"], (int, float))
and not isinstance(field_schema["exclusiveMaximum"], bool)
):
maximum_val = str(field_schema["exclusiveMaximum"])
maximum_exclusive = True
elif "maximum" in field_schema:
elif (
"maximum" in field_schema
and isinstance(field_schema["maximum"], (int, float))
and not isinstance(field_schema["maximum"], bool)
):
maximum_val = str(field_schema["maximum"])

# Default
Expand Down
Loading