Allow for VID input - #74
Merged
Merged
Conversation
pmigueld
marked this pull request as draft
March 3, 2022 09:53
danicaerediano
left a comment
danicaerediano
left a comment
Collaborator
There was a problem hiding this comment.
I get error Invalid id::VID is revoked on entering 111111 as OTP for the 16 digits code
Collaborator
Author
This is expected since VID is temporary, right @uocnb? |
Member
@pmigueld this depends on type of generated VID. It is defined by
|
pmigueld
force-pushed
the
feature/72-allow-for-uin-and-vid
branch
3 times, most recently
from
March 11, 2022 08:48
058f589 to
4ba53f2
Compare
pmigueld
marked this pull request as ready for review
March 11, 2022 09:23
pmigueld
force-pushed
the
feature/72-allow-for-uin-and-vid
branch
from
March 17, 2022 06:26
4ba53f2 to
6ec5e06
Compare
kneckinator
self-requested a review
March 18, 2022 02:02
kneckinator
approved these changes
Mar 18, 2022
kneckinator
left a comment
kneckinator
left a comment
Collaborator
There was a problem hiding this comment.
Let's merge this and adapt if/when the VID format changes on the MOSIP side.
pmigueld
pushed a commit
that referenced
this pull request
Jan 26, 2024
fix(INJI-92): show proper UI messages for deactivated UIN and VID
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially resolves #72
Needs backend changes to accept VID when downloading credential. VC will get stuck at loading status trying to download otherwise.