RFC: Annotate view

[idursun]

Hi folks,

A couple of months ago I wrote myself a helper TUI that I used to review the AI generated code. It shows the diff and allows me to comment on any part of the changes. I've been using it for quite some time and wanted to have something similar in jjui.

I now adapted that code to work inside jjui which is sitting in the annotate-view branch. I've been using the build that included it for some time now and find it quite useful. I am curious to hear your comments if this is something useful for others and if you would like to see it included in jjui.

From the revisions view, you can press Shift+C to open the annotation view for the selected revision.

It initially shows the revision’s diff, one file at a time, with line numbers and syntax highlighting. You can move through commentable lines with j/k, select a range with Shift+J/Shift+K, and press c to add a comment. Comments appear directly below the selected code.

Pressing v switches between the diff and the complete file. The full-file view is useful when you need more context or want to comment on an unchanged line.

While reviewing, you can:

• Move between changed files with [ and ].
• Open the file picker with Ctrl+T.
• Move to a child or parent revision with { and }.
• Open the list of collected comments with t.
• Edit a comment with c or delete it with x.
• Toggle line wrapping with w.
• Copy all comments as Markdown with y.

Comments are kept while you move between files and revisions. When you are finished, the copied Markdown contains the file, line range, selected diff, and your comment, ready to paste into a discussion, issue, or another tool.

That's pretty much it. I am curious to hear your comments.

I’m away for the next two weeks, so I’m dropping this here before I go. My responses may be a little delayed, but I’ll catch up when I’m back.

[Doran-Penner]

This looks really great! I've been trying to do my code review locally for a while, and this feature would be super handy. To get a more compete picture, I'll need to try it out — in particular I want to see how it can save/export the annotations. But this is awesome :)

[seh]

This overlaps somewhat with the crit tool, but I'd like to be able to perform this kind of review in jjui as well.

Is implementing a search facility feasible? That jjui's diff view still lacks search is the impediment that has me invoking jj diff outside of jjui.

[baggiiiie]

i just tried it out and this is neat!

wondering if we would have more experiments like this in the future, the proposed [features] config might be handy