Skip to content

Adds Regex to modify JSON Stings to match csv spec. #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 34 commits into from
Jun 19, 2020
Merged

Adds Regex to modify JSON Stings to match csv spec. #166

merged 34 commits into from
Jun 19, 2020

Conversation

@denstre
Copy link
Contributor

@denstre denstre commented Jun 8, 2020 •
edited
Loading

TODO: (Reminder for myself)

Resolves #141

  • Adapt Tests

  • Adapt Factory (convert double double quotes ("") to double quotes("))

@denstre denstre added bug Something isn't working invalid This doesn't seem right labels Jun 8, 2020
@denstre denstre added this to the Version 1.0.1 milestone Jun 8, 2020
@denstre denstre requested review from ckittl and johanneshiry June 8, 2020 18:46
@denstre denstre self-assigned this Jun 8, 2020
denstre
denstre commented Jun 8, 2020
View reviewed changes
@codecov
Copy link

codecov bot commented Jun 8, 2020 •
edited
Loading

Codecov Report

Merging #166 into master will increase coverage by 0.89%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #166      +/-   ##
============================================
+ Coverage     74.77%   75.67%   +0.89%     
- Complexity     1469     1521      +52     
============================================
  Files           206      206              
  Lines          5991     6015      +24     
  Branches        579      580       +1     
============================================
+ Hits           4480     4552      +72     
+ Misses         1163     1116      -47     
+ Partials        348      347       -1
Impacted Files Coverage Δ Complexity Δ
...edu/ie3/datamodel/io/source/csv/CsvDataSource.java 92.12% <0.00%> (+0.61%) 53.00% <0.00%> (+5.00%)
...edu/ie3/datamodel/models/input/system/PvInput.java 75.28% <0.00%> (+1.12%) 14.00% <0.00%> (+1.00%)
...s/input/connector/type/Transformer3WTypeInput.java 71.64% <0.00%> (+1.49%) 24.00% <0.00%> (+1.00%)
...del/models/input/connector/Transformer3WInput.java 74.19% <0.00%> (+1.61%) 13.00% <0.00%> (+1.00%)
...u/ie3/datamodel/models/input/system/LoadInput.java 67.21% <0.00%> (+1.63%) 10.00% <0.00%> (+1.00%)
...3/datamodel/models/input/MeasurementUnitInput.java 67.30% <0.00%> (+1.92%) 10.00% <0.00%> (+1.00%)
...e3/datamodel/models/input/connector/LineInput.java 72.00% <0.00%> (+2.00%) 10.00% <0.00%> (+1.00%)
...s/input/connector/type/Transformer2WTypeInput.java 73.46% <0.00%> (+2.04%) 17.00% <0.00%> (+1.00%)
...edu/ie3/datamodel/models/input/system/BmInput.java 72.91% <0.00%> (+2.08%) 9.00% <0.00%> (+1.00%)
...du/ie3/datamodel/models/input/system/ChpInput.java 72.91% <0.00%> (+2.08%) 9.00% <0.00%> (+1.00%)
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d6d3af...a645e62. Read the comment docs.

@denstre denstre marked this pull request as draft June 8, 2020 18:52
ckittl
ckittl suggested changes Jun 15, 2020
View reviewed changes
@ckittl
Copy link
Member

ckittl commented Jun 15, 2020

Additionally: Please move the quotation handling from BufferedCsvWriter to CsvFileSink. The sink suits better, as it could use different other csv writers via it's connector. Then the quotation handling would have to be implemented in every future implementation of the writer.

@ckittl ckittl linked an issue Jun 15, 2020 that may be closed by this pull request
Add quotation marks to all special fields when writing .csv files #141
Closed
3 tasks
@denstre
Copy link
Contributor Author

denstre commented Jun 15, 2020

!test

@denstre
Copy link
Contributor Author

denstre commented Jun 16, 2020

!test

1 similar comment
@denstre
Copy link
Contributor Author

denstre commented Jun 16, 2020

!test

@johanneshiry
Copy link
Member

johanneshiry commented Jun 17, 2020

!test

@johanneshiry
Copy link
Member

johanneshiry commented Jun 17, 2020 •
edited
Loading

Won't compile until PowerSystemUtils#33 is merged and deployed

@johanneshiry johanneshiry requested review from ckittl and removed request for ckittl June 17, 2020 11:00
ckittl
ckittl suggested changes Jun 18, 2020
View reviewed changes
johanneshiry and others added 3 commits June 18, 2020 13:02
@johanneshiry @ckittl
Update src/main/java/edu/ie3/datamodel/io/sink/CsvFileSink.java
d7ea57d 
Co-authored-by: Chris Kittl <44838605+ckittl@users.noreply.github.com>
@johanneshiry
added sonatype snapshot repo
3831a3c
@johanneshiry
- set CsvDataSource to RFC 4180 valid parsing
2d10c3d 
- extensive tests for new parsing
ckittl
ckittl suggested changes Jun 18, 2020
View reviewed changes
@johanneshiry johanneshiry requested a review from ckittl June 18, 2020 19:38
@ckittl ckittl merged commit 6a3f099 into master Jun 19, 2020
@ckittl ckittl deleted the ds/#141-adapt-jsonstrings-for-csv-rev2 branch June 19, 2020 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johanneshiry johanneshiry Awaiting requested review from johanneshiry

1 more reviewer

@ckittl ckittl ckittl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@denstre denstre

Labels

bug Something isn't working invalid This doesn't seem right

Projects

None yet

Milestone

Version 1.1

Development

Successfully merging this pull request may close these issues.

Add quotation marks to all special fields when writing .csv files

4 participants

@denstre @ckittl @johanneshiry