Skip to content

CSV data converter to comply with the CSV specification RFC 4180 #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 18, 2020
Merged

CSV data converter to comply with the CSV specification RFC 4180 #33

merged 12 commits into from
Jun 18, 2020

Conversation

@denstre
Copy link
Contributor

@denstre denstre commented Jun 16, 2020 •
edited
Loading

@denstre denstre added the enhancement New feature or request label Jun 16, 2020
@denstre denstre requested review from ckittl and johanneshiry June 16, 2020 13:41
@denstre denstre self-assigned this Jun 16, 2020
@codecov
Copy link

codecov bot commented Jun 16, 2020 •
edited
Loading

Codecov Report

Merging #33 into master will increase coverage by 0.74%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #33      +/-   ##
============================================
+ Coverage     23.79%   24.53%   +0.74%     
- Complexity       75       85      +10     
============================================
  Files            29       29              
  Lines          1017     1027      +10     
  Branches        134      137       +3     
============================================
+ Hits            242      252      +10     
  Misses          769      769              
  Partials          6        6
Impacted Files Coverage Δ Complexity Δ
...mutils/src/main/java/edu/ie3/util/StringUtils.java 94.28% <0.00%> (+2.28%) 21.00% <0.00%> (+10.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c76ba8c...75416a1. Read the comment docs.

@johanneshiry
Copy link
Member

johanneshiry commented Jun 16, 2020

@ckittl I adapted the proposal of @denstre as discussed. Pls double check if this makes sense and if you think its documented enough

@johanneshiry johanneshiry requested review from ckittl and removed request for ckittl June 17, 2020 07:13
@johanneshiry johanneshiry mentioned this pull request Jun 17, 2020
Merged
2 tasks
ckittl
ckittl suggested changes Jun 17, 2020
View reviewed changes
ckittl
ckittl approved these changes Jun 18, 2020
View reviewed changes
@ckittl ckittl merged commit 983bed8 into master Jun 18, 2020
@ckittl ckittl deleted the ds/#141-csv-converter-method branch June 18, 2020 11:22
@t-ober t-ober mentioned this pull request Apr 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johanneshiry johanneshiry Awaiting requested review from johanneshiry

1 more reviewer

@ckittl ckittl ckittl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@denstre denstre

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@denstre @johanneshiry @ckittl