Skip to content

fix(publish): match allowed filenames case-insensitively - #773

Merged
XiaoSeS merged 2 commits into
iflytek:mainfrom
FenjuFu:fix/publish-case-insensitive-whitelist
Aug 31, 2026
Merged

fix(publish): match allowed filenames case-insensitively#773
XiaoSeS merged 2 commits into
iflytek:mainfrom
FenjuFu:fix/publish-case-insensitive-whitelist

Conversation

@FenjuFu

@FenjuFu FenjuFu commented Aug 28, 2026

Copy link
Copy Markdown
Member

Summary

  • Normalize both configured allowlist entries and package paths with Locale.ROOT before matching.
  • Add a regression test covering a conventionally capitalized Makefile.
  • Restore CLI/API publishing for packages whose explicitly allowed filenames contain uppercase letters.

Validation

  • Backend tests passed
  • Frontend typecheck and lint passed
  • OpenAPI contract unchanged; regeneration not applicable
  • Staging smoke test not run (Docker is unavailable on this machine; no API or operator workflow changed)

Commands run:

.\mvnw.cmd -pl skillhub-domain -am "-Dtest=SkillPackageValidatorTest" "-Dsurefire.failIfNoSpecifiedTests=false" test
# 21 tests, 0 failures

.\mvnw.cmd -pl skillhub-domain -am test
# 443 domain + 21 storage tests, 0 failures

pnpm run typecheck
pnpm run lint

The repository's full skillhub-app dependency-suite command was also attempted. The local executor timed out after six minutes while it was still progressing (97 Surefire reports generated, no failures observed); GitHub CI remains the authoritative full-suite run.

Risk

  • User-facing impact: explicitly allowed filenames now match case-insensitively as intended.
  • Deployment or migration impact: none.
  • Rollback approach: revert the single commit.

Notes

FenjuFu and others added 2 commits August 28, 2026 17:57
Signed-off-by: FenjuFu <92919259+FenjuFu@users.noreply.github.com>
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
@XiaoSeS
XiaoSeS force-pushed the fix/publish-case-insensitive-whitelist branch from 84be6c0 to 9f3b10d Compare August 31, 2026 06:01
@XiaoSeS
XiaoSeS merged commit 49ef09d into iflytek:main Aug 31, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] 上传扩展名白名单无法匹配含大写字母的文件名(Makefile/Dockerfile/CODEOWNERS)

2 participants