feat: changed Dockerfile to handle hermes in gateway mode#22
Conversation
| # notice into the first conversation it sees. The Domyn worker is already | ||
| # bound to one channel, so we just point the home target at it — cron | ||
| # results and broadcasts go back to the same channel. | ||
| DOMYN_HOME_CHANNEL=${DOMYN_CHANNEL_ID} |
There was a problem hiding this comment.
should we move this things as defaults in the plugin instead of allowing the user to mess up with them?
There was a problem hiding this comment.
wait how can we default domyn-channel-id?
| # so we typically delegate fully and accept any author arriving on the | ||
| # subscribed channel. Without this, unknown users get a pairing prompt: | ||
| # "Hi~ I don't recognize you yet! Here's your pairing code: …" | ||
| DOMYN_ALLOW_ALL_USERS=true |
There was a problem hiding this comment.
I guess this ties back to the comments I made here.
https://github.com/igeniusai/domyn-agents/pull/387/changes
But also about this, do we really want the developer to set this? What is the expected journey for the dev?
| # in a daemon thread, and AGENT_START events injected from the platform | ||
| # drive the conversation. | ||
| CMD ["hermes", "chat"] | ||
| RUN pip install --no-cache-dir wheels/domyn_agents-*.whl langchain-core |
There was a problem hiding this comment.
does hermes require langchain? I am surprised
There was a problem hiding this comment.
it's because of a dependency in domyn expose, i was planning to remove it after the domyn expose PR from gabriele was merged, to avoid useless merge conflicts
| # status message — disruptive in a chat UI. "queue" silently FIFO-s | ||
| # the new message behind the current one; nothing visible until the | ||
| # current turn completes. "steer" injects as additional context. | ||
| busy_input_mode: queue |
There was a problem hiding this comment.
I guess this will conflict with stopping executions in flight, but we'll make some tests after merging this and rebasing the stop stuff
|
Approved but about the authentication part I would like to understand more what you are expecting as a standard flow, so we might want to wait to close that discussion to merge if we want to change anything |
3 participants
No description provided.