Skip to content

Ice - new test and minor changes#88

Merged
AgnieszkaMakulska merged 7 commits into
igfuw:masterfrom
AgnieszkaMakulska:ice
May 15, 2026
Merged

Ice - new test and minor changes#88
AgnieszkaMakulska merged 7 commits into
igfuw:masterfrom
AgnieszkaMakulska:ice

Conversation

@AgnieszkaMakulska
Copy link
Copy Markdown
Contributor

  • adding a test comparing results of lagrangian and bulk ice microphysics
  • spectrum of ice_a and ice_c can be diagnosed
  • rd_insol included in the "aerosol" dict

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the parcel-model ice workflow by (1) adding/adjusting long tests that compare Lagrangian vs bulk ice results and generate diagnostic plots, and (2) evolving the aerosol configuration to include rd_insol inside the aerosol JSON spec (plus a new depo toggle for depositional growth).

Changes:

  • Require rd_insol inside each aerosol mode definition (update defaults + tests accordingly).
  • Add depo option and wire it into the Lagrangian microphysics step.
  • Add/adjust long tests and plotting outputs for warm/ice scheme comparisons; extend spectrum diagnostics to support drwt = ice_a/ice_c.

Reviewed changes

Copilot reviewed 17 out of 18 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
unit_test/test_RH.py Updates aerosol JSON in RH test to include rd_insol.
unit_test/test_moments.py Updates aerosol JSON fixture to include rd_insol.
unit_test/test_init.py Updates parametrized aerosol cases to include rd_insol.
unit_test/test_chem_henry.py Updates aerosol JSON in chemistry Henry-law test to include rd_insol.
parcel.py Adds depo kwarg; updates default aerosol JSON to include rd_insol; updates docstring.
parcel_common.py Enforces presence of rd_insol in aerosol dict validation.
micro_lgrngn.py Uses aerosol-provided rd_insol in distribution key; forwards depo to libcloudphxx options.
io_output.py Adds support for diagnosing ice_a/ice_c spectra; tweaks bin metadata description.
functions.py Adds helper converting RH w.r.t liquid to RH w.r.t ice.
chem_conditions.py Adds rd_insol into chemistry example aerosol JSON.
long_test/test_timestep.py Updates aerosol JSON to include rd_insol.
long_test/test_plot_schemes_warm.py Uses common.rho_w and renames output plot file to warm-specific name.
long_test/test_compare_schemes_warm.py Uses common.rho_w for condensed-water conversion.
long_test/test_bulk_ice.py Updates docstring to reflect current bulk-ice invocation.
long_test/test_plot_schemes_ice.py New long test for ice-scheme comparison plot generation.
long_test/test_plot_ice_SD.py Improves plot styling/labels; switches plot outputs to SVG; passes rd_insol via aerosol JSON; enables depo.
long_test/test_ice_SD.py Enables depo; moves rd_insol into aerosol JSON; removes rd_insol kwarg usage.
plots/outputs/plot_schemes_ice.svg Adds checked-in generated SVG artifact for ice-scheme comparison plot.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread io_output.py
Comment thread io_output.py Outdated
Comment thread parcel.py
Comment thread long_test/test_plot_schemes_ice.py Outdated
Comment thread long_test/test_plot_schemes_ice.py Outdated
@AgnieszkaMakulska AgnieszkaMakulska merged commit 4ce3acc into igfuw:master May 15, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants