refactor: snake_case attr-comb options & arguments, soft-deprecate dotted names#2742
Open
schochastics wants to merge 1 commit into
Open
refactor: snake_case attr-comb options & arguments, soft-deprecate dotted names#2742schochastics wants to merge 1 commit into
schochastics wants to merge 1 commit into
Conversation
Contributor
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 1453158 is merged into feat-attrib_comb:
|
schochastics
force-pushed
the
par-attr-comb-options
branch
from
July 15, 2026 19:10
1453158 to
2f878f3
Compare
Contributor
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 2f878f3 is merged into main:
|
This was referenced Jul 26, 2026
Contributor
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if ba22989 is merged into main:
|
…tted names Rename the attribute-combination options and arguments to snake_case: `edge.attr.comb` -> `edge_attr_combine` and `vertex.attr.comb` -> `vertex_attr_combine`, both as igraph options and as arguments to `simplify()`, `as_undirected()`, and `contract()`. The dotted argument names keep working behind `...` under a single soft-deprecation, via generated ARG_HANDLE blocks driven by the new tools/migrations/attr-comb.R registry file. Dotted option names are soft-deprecated with a warning shim. Also point the stale schema references in sibling registry files and helper comments at tools/migrations/README.md, where the schema documentation lives since the registry was split into per-topic files. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016M32izVHZPfxAqemAe4BrX
krlmlr
force-pushed
the
par-attr-comb-options
branch
from
July 26, 2026 19:29
ba22989 to
c5de7bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out from #2676 per review feedback ("I'd like to review the par code in a separate PR"). #2676 kept the original dotted option/argument names; this PR carries the naming refactor on its own so it can be reviewed in isolation.
What this does
vertex.attr.comb→vertex_attr_combine,edge.attr.comb→edge_attr_combine, and the newgraph.attr.comb→graph_attr_combine. Reading/setting the old dotted keys still works via back-compatible aliasing inigraph_opt()/igraph_options(), emitting a singlelifecycle::deprecate_soft()warning (R/par.R).simplify(),as_undirected()andcontract()gain snake_caseedge_attr_combine/vertex_attr_combinearguments via the argument-migration infrastructure (registry entries intools/migrations/attr-comb.R, spliced byRscript tools/generate-migrations.R; schema intools/migrations/README.md); the dotted names keep working and soft-deprecate.union()/intersection()/compose()/disjoint_union()use the snake_case*_combineargument names.types-RR.yaml), regenerated*_impldefaults, and the affected tests/snapshots.tools/migrations.Rschema references in sibling registry files and helper comments attools/migrations/README.md, where the schema documentation lives since the registry split (refactor(migrations): split the registry into per-topic files #2779).Base branch
#2676 has merged, so this PR is based on
mainand rebased into a single commit on top of it; the attr-comb migration entries live in their own registry filetools/migrations/attr-comb.Rso that the open per-topic migration PRs can append toconversion.R,community.R, etc. without conflicting here.