refactor: move optional arguments of similarity-efficiency functions behind the ellipsis#2776
Open
krlmlr wants to merge 2 commits into
Open
refactor: move optional arguments of similarity-efficiency functions behind the ellipsis#2776krlmlr wants to merge 2 commits into
krlmlr wants to merge 2 commits into
Conversation
krlmlr
force-pushed
the
claude/ellipsis-similarity-efficiency
branch
from
July 26, 2026 10:52
a0f8904 to
752e97a
Compare
Contributor
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 752e97a is merged into main:
|
krlmlr
marked this pull request as ready for review
July 26, 2026 15:03
krlmlr
force-pushed
the
claude/ellipsis-similarity-efficiency
branch
from
July 26, 2026 16:24
752e97a to
0f7d122
Compare
…behind the ellipsis Insert `...` between the defining arguments and the optional modifiers of 6 functions, following the zoning rules in CONTRIBUTING.md. Legacy positional and abbreviated calls are recovered by the generated ARG_HANDLE blocks (registry: tools/migrations/similarity-efficiency.R) and emit a single soft deprecation for igraph 3.0.0. No defaults change and no arguments are renamed. Functions: assortativity_degree, assortativity_nominal, average_local_efficiency, global_efficiency, local_efficiency, similarity Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016M32izVHZPfxAqemAe4BrX
Same fix as #2781: the migration rewriter collapsed multi-line enum defaults and air skips c() calls, so restore the original layout. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016M32izVHZPfxAqemAe4BrX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the repo-wide ellipsis migration coordinated in #2757 —
see that PR for the full rationale (CONTRIBUTING.md, Argument Order and the Ellipsis).
Based directly on
main(the registry split landed via #2779); a single topic commit.What this does
Inserts
...between the defining arguments (head) and the optionalmodifiers (tail) of 6 exported similarity-efficiency functions.
Arguments after
...become keyword-only.ARG_HANDLE block and emit a single
lifecycle::deprecate_soft("3.0.0", …)—behavior is unchanged.
tools/migrations/similarity-efficiency.R; blocks regenerated viaRscript tools/generate-migrations.R(idempotent, CI-checked).New signatures
assortativity_degree()graphdirectedassortativity_nominal()graph, typesdirected, normalizedaverage_local_efficiency()graphweights, directed, modeglobal_efficiency()graphweights, directedlocal_efficiency()graph, vidsweights, directed, modesimilarity()graph, vidsmode, loops, methodNotes for review
igraph.r2cdocs(GitHub API unreachable), so
man/*.Rdfiles were updated mechanically(usage +
...argument item) instead of viadevtools::document().R CMD check's usage↔formals validation passes; a follow-up
devtools::document()run may reflow whitespace but should produce nosemantic diff.
named arguments (they are the same soft-deprecation user code will see).