ci: Move the revdep2 library artifact steps to their Node 24 releases - #2817
Merged
Conversation
#2813 moved the repository off Node 20, and #2814 reintroduced it two commits later: the prebuilt-library steps it added pinned `actions/upload-artifact@v5` and `actions/download-artifact@v6`, both of which still target Node 20. Every preflight and shard job has warned about it since. These were the last three non-current pins in the workflows; the rest of the repository was already on `upload-artifact@v6` and `download-artifact@v7`. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RLy6bf4Zo8YWgv5Qb53nmY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why the Node 20 warnings came back
#2813 moved the repository off Node 20.
#2814 reintroduced it two commits later:
the prebuilt-library steps it added to
revdep2.yamlwere pinned to
actions/upload-artifact@v5andactions/download-artifact@v6,both of which still target Node 20,
while the other twenty-one artifact steps in the repository
were already on
@v6/@v7.So every preflight job has warned
and every shard job the same for
actions/download-artifact@v6.The change
Three pins, all in
revdep2.yaml:revdep2-libupload-artifact@v5upload-artifact@v6revdep2-lib-indexupload-artifact@v5upload-artifact@v6revdep2-libin a sharddownload-artifact@v6download-artifact@v7No inputs changed; the same input names are supported by the newer majors,
and the rest of the workflow already used them.
After this, the only remaining
@v5pins areactions/cache,where v5 is current and already runs on Node 24.
🤖 Generated with Claude Code
https://claude.ai/code/session_01RLy6bf4Zo8YWgv5Qb53nmY
Generated by Claude Code