Skip to content

docs: other roxygen2 warning - #2870

Merged
krlmlr merged 2 commits into
mainfrom
solve
Sep 3, 2026
Merged

docs: other roxygen2 warning#2870
krlmlr merged 2 commits into
mainfrom
solve

Conversation

@maelle

@maelle maelle commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Or should it be Matrix::solve()?

@maelle
maelle requested a review from schochastics August 28, 2026 11:03
@github-actions

Copy link
Copy Markdown
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if a1807de is merged into main:

  • ✔️as_adjacency_matrix: 646ms -> 643ms [-1.78%, +0.93%]
  • ✔️as_biadjacency_matrix: 668ms -> 662ms [-2.99%, +1.06%]
  • ✔️as_data_frame_both: 1.33ms -> 1.34ms [-0.97%, +2.29%]
  • ✔️as_long_data_frame: 3.23ms -> 3.23ms [-1.21%, +1.36%]
  • ✔️es_attr_filter: 2.16ms -> 2.14ms [-3.1%, +1.11%]
  • ✔️graph_from_adjacency_matrix: 134ms -> 135ms [-1.83%, +1.94%]
  • ✔️graph_from_data_frame: 3.05ms -> 3.02ms [-2.65%, +1.22%]
  • ✔️vs_attr_filter: 1.25ms -> 1.24ms [-2.71%, +1.58%]
  • ✔️vs_by_name: 791µs -> 804µs [-0.42%, +3.63%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

@schochastics

Copy link
Copy Markdown
Contributor

I think this should be Matrix::solve()

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if eb9f389 is merged into main:

  • ✔️as_adjacency_matrix: 864ms -> 871ms [-0.46%, +1.95%]
  • ✔️as_biadjacency_matrix: 897ms -> 898ms [-1.6%, +1.79%]
  • ✔️as_data_frame_both: 1.88ms -> 1.86ms [-2.91%, +0.39%]
  • ✔️as_long_data_frame: 4.36ms -> 4.43ms [-1.56%, +4.88%]
  • ✔️es_attr_filter: 3.21ms -> 3.19ms [-3.81%, +2.64%]
  • ✔️graph_from_adjacency_matrix: 160ms -> 163ms [-2.43%, +5.83%]
  • ✔️graph_from_data_frame: 4.11ms -> 4.09ms [-2.64%, +1.45%]
  • ✔️vs_attr_filter: 1.85ms -> 1.9ms [-2.2%, +7.26%]
  • ✔️vs_by_name: 1.18ms -> 1.2ms [-1.39%, +3.22%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

@krlmlr
krlmlr merged commit a52ba87 into main Sep 3, 2026
9 checks passed
@krlmlr
krlmlr deleted the solve branch September 3, 2026 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants