Skip to content

Install 3rd party type stubs for mypy#484

Merged
khaeru merged 1 commit into
mainfrom
hotfix/mypy-0.900
Jun 15, 2021
Merged

Install 3rd party type stubs for mypy#484
khaeru merged 1 commit into
mainfrom
hotfix/mypy-0.900

Conversation

@khaeru
Copy link
Copy Markdown
Member

@khaeru khaeru commented Jun 15, 2021

As part of #327, the mypy step of the lint workflow began to fail.

This is because mypy 0.900 et seq. were released; in these versions (unlike mypy 0.8xx), type stubs for 3rd-party packages are not bundled and must be installed separately.

This PR adds these to lint.yaml:

  • types-requests
  • types-PyYAML
  • types-pkg_resources

How to review

No review/FYI only: changes to CI.

PR checklist

  • Continuous integration checks all ✅
  • Add or expand tests; coverage checks both ✅
  • Add, expand, or update documentation. N/A, CI only
  • Update release notes.

@khaeru khaeru added the ci Continuous integration label Jun 15, 2021
@khaeru khaeru self-assigned this Jun 15, 2021
@khaeru khaeru mentioned this pull request Jun 15, 2021
12 tasks
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 15, 2021

Codecov Report

Merging #484 (18faabf) into main (d52370b) will not change coverage.
The diff coverage is n/a.

❗ Current head 18faabf differs from pull request most recent head d1d6166. Consider uploading reports for the commit d1d6166 to get more accurate results

@@          Coverage Diff          @@
##            main    #484   +/-   ##
=====================================
  Coverage   93.3%   93.3%           
=====================================
  Files         37      37           
  Lines       2819    2819           
=====================================
  Hits        2632    2632           
  Misses       187     187           

@khaeru khaeru merged commit 56611ad into main Jun 15, 2021
@khaeru khaeru deleted the hotfix/mypy-0.900 branch June 15, 2021 09:10
@khaeru khaeru mentioned this pull request Dec 2, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant