Install 3rd party type stubs for mypy#484
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #484 +/- ##
=====================================
Coverage 93.3% 93.3%
=====================================
Files 37 37
Lines 2819 2819
=====================================
Hits 2632 2632
Misses 187 187 |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of #327, the mypy step of the lint workflow began to fail.
This is because mypy 0.900 et seq. were released; in these versions (unlike mypy 0.8xx), type stubs for 3rd-party packages are not bundled and must be installed separately.
This PR adds these to lint.yaml:
How to review
No review/FYI only: changes to CI.
PR checklist
Add or expand tests;coverage checks both ✅Add, expand, or update documentation.N/A, CI onlyUpdate release notes.