(MOT-4299) feat: make release channel selectable - #694
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughThe release workflow now accepts ChangesRegistry channel release flow
Harness workflow permissions
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant CreateTag
participant ReleasePipeline
participant CandidateValidation
participant PromoteWorker
participant Registry
CreateTag->>ReleasePipeline: select next or latest
alt next
ReleasePipeline->>CandidateValidation: validate candidate
CandidateValidation->>PromoteWorker: approve promotion
PromoteWorker->>Registry: publish stable release
else latest
ReleasePipeline->>Registry: publish directly as stable release
end
Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
skill-check — worker0 verified, 54 skipped (no docs/).
Four for four. Nicely done. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/sops/release.md`:
- Around line 61-65: Update the release diagram around setupJob and channel to
route both latest and next through the shared binary-build, container-build,
bundle-build, and publish stages. Preserve candidate smoke, evidence, and
promotion steps exclusively on the next branch, while keeping latest’s path
leading to the normal GitHub Release.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 65e6ad72-a2f3-4952-a64a-b033a5a64ba4
📒 Files selected for processing (3)
.github/workflows/create-tag.yml.github/workflows/release.ymldocs/sops/release.md
| createTag[Create Tag] -->|"tag worker/vX.Y.Z"| setupJob[setup] | ||
| setupJob --> ghRelease[create public GitHub prerelease] | ||
| setupJob --> channel{registry-tag} | ||
| channel -->|latest| directPublish[publish directly to latest] | ||
| directPublish --> normalRelease[normal GitHub Release] | ||
| channel -->|next| ghRelease[create public GitHub prerelease] |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Show the shared build path for latest.
The diagram routes latest from setup directly to publish. In .github/workflows/release.yml, publish requires binary-build, container-build, and bundle-build, so both channels require the build stages before publication. Update the diagram to show the shared build and publish path. Keep candidate smoke, evidence, and promotion on the next branch only.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/sops/release.md` around lines 61 - 65, Update the release diagram around
setupJob and channel to route both latest and next through the shared
binary-build, container-build, bundle-build, and publish stages. Preserve
candidate smoke, evidence, and promotion steps exclusively on the next branch,
while keeping latest’s path leading to the normal GitHub Release.
1 participant
Summary
nextlatestactions: writepermission required by its nested dispatcherBehavior
next: publish the candidate, run candidate validation, and promote manually tolatestlatest: publish directly to the Registrylatestchannel without candidate promotionValidation
bash -n harness/tests/quickstart/run-ci.shgit diff --checkPytest was not available in the local environment.
Refs MOT-4299
Summary by CodeRabbit
New Features
nextorlatestregistry channel.latestchannel can publish directly without candidate validation or manual promotion.Documentation