Skip to content

chore: regenerate provider lock files for llm-router 1.4.1 - #696

Closed
ytallo wants to merge 1 commit into
mainfrom
chore/provider-lockfiles-llm-router-141
Closed

chore: regenerate provider lock files for llm-router 1.4.1#696
ytallo wants to merge 1 commit into
mainfrom
chore/provider-lockfiles-llm-router-141

Conversation

@ytallo

@ytallo ytallo commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Summary

Sync all nine provider workers' Cargo.lock files to the llm-router 1.4.1 bump (531b140), which updated only the router's own manifest. Every provider pins llm-router as a path dependency, so their stale locks (1.4.0; llamacpp/xai still at 1.3.2) break any --locked build.

Impact

First Harness E2E run on main after the bump (30955188907) failed in the build job before any scenario started:

error: cannot update the lock file .../provider-deepseek/Cargo.lock because --locked was passed

Every provider in the E2E matrix (subject deepseek, judge zai) is affected — deepseek just failed first. All nine locks now resolve cleanly under --locked (cargo tree --locked).

Follow-up worth considering

The llamacpp/xai locks were stale across two bumps — the worker-bump tooling never regenerates dependent providers' locks. A bump-time hook (or CI check) that runs cargo update -p llm-router across provider-*/ would prevent recurrence.

The llm-router 1.4.1 bump (531b140) updated only the router's own
manifest, leaving every provider worker's Cargo.lock pinning a stale
llm-router path-dependency version (1.4.0, and 1.3.2 for llamacpp/xai).
The Harness E2E build compiles providers with --locked, so the first
E2E run on main after the bump failed before any scenario started:
'cannot update the lock file provider-deepseek/Cargo.lock'.

Sync all nine provider locks; each resolves cleanly under --locked.
@ytallo ytallo added the no-ticket PR deliberately has no Linear ticket (bump/typo/CI-only) label Aug 4, 2026
@vercel

vercel Bot commented Aug 4, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
workers Ready Ready Preview Aug 4, 2026 11:08pm
workers-tech-spec Ready Ready Preview Aug 4, 2026 11:08pm

Request Review

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (9)
  • provider-anthropic/Cargo.lock is excluded by !**/*.lock
  • provider-claude-code/Cargo.lock is excluded by !**/*.lock
  • provider-deepseek/Cargo.lock is excluded by !**/*.lock
  • provider-kimi/Cargo.lock is excluded by !**/*.lock
  • provider-llamacpp/Cargo.lock is excluded by !**/*.lock
  • provider-openai-codex/Cargo.lock is excluded by !**/*.lock
  • provider-openai/Cargo.lock is excluded by !**/*.lock
  • provider-xai/Cargo.lock is excluded by !**/*.lock
  • provider-zai/Cargo.lock is excluded by !**/*.lock

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c0d02410-eff4-4209-90ea-3ef2173997c0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

skill-check — worker

0 verified, 54 skipped (no docs/).

Layer Result
structure
vale
ai
render

Four for four. Nicely done.

@ytallo

ytallo commented Aug 4, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by the feature-gate PR — the lock regeneration alone exposed that providers now need a Node toolchain to compile llm-router 1.4.1's build.rs; the successor PR fixes that structurally and carries these same lock updates.

@ytallo ytallo closed this Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-ticket PR deliberately has no Linear ticket (bump/typo/CI-only)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant