Skip to content

Avoid retrying ephemeral stack replacements - #868

Merged
ytallo merged 2 commits into
mainfrom
feat/e2e-stack-settle
Aug 20, 2026
Merged

Avoid retrying ephemeral stack replacements#868
ytallo merged 2 commits into
mainfrom
feat/e2e-stack-settle

Conversation

@ytallo

@ytallo ytallo commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Summary

  • avoid --force in the fresh ephemeral stack bootstrap
  • prevent a retry after a transient Registry error from restarting workers that already booted
  • retain the fail-closed runtime version verification added in Fix ephemeral target worker repinning #867

Validation

  • bash -n harness/tests/e2e/run-shadow-control-ci.sh
  • python3 .github/scripts/tests/test_harness_e2e_shadow_contract.py
  • PYTHONPATH=.github/scripts python3 -m unittest discover -s .github/scripts/tests -p "test_*.py"

@vercel

vercel Bot commented Aug 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
workers Ready Ready Preview Aug 20, 2026 4:59pm
workers-tech-spec Ready Ready Preview Aug 20, 2026 4:59pm

Request Review

@ytallo ytallo added the no-ticket PR deliberately has no Linear ticket (bump/typo/CI-only) label Aug 20, 2026
@ytallo
ytallo marked this pull request as ready for review August 20, 2026 16:55
@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@ytallo, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 18 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: aaa559ba-7191-45f7-8a80-21ba77812d90

📥 Commits

Reviewing files that changed from the base of the PR and between ceacb4f and 939ae45.

⛔ Files ignored due to path filters (13)
  • crates/provider-integration-testkit/Cargo.lock is excluded by !**/*.lock
  • provider-anthropic/Cargo.lock is excluded by !**/*.lock
  • provider-claude-code/Cargo.lock is excluded by !**/*.lock
  • provider-deepseek/Cargo.lock is excluded by !**/*.lock
  • provider-github-copilot/Cargo.lock is excluded by !**/*.lock
  • provider-kimi/Cargo.lock is excluded by !**/*.lock
  • provider-llamacpp/Cargo.lock is excluded by !**/*.lock
  • provider-openai-codex/Cargo.lock is excluded by !**/*.lock
  • provider-openai/Cargo.lock is excluded by !**/*.lock
  • provider-opencode-go/Cargo.lock is excluded by !**/*.lock
  • provider-openrouter/Cargo.lock is excluded by !**/*.lock
  • provider-xai/Cargo.lock is excluded by !**/*.lock
  • provider-zai/Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • .github/scripts/tests/test_harness_e2e_shadow_contract.py
  • harness/tests/e2e/run-shadow-control-ci.sh

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

skill-check — worker

0 verified, 62 skipped (no docs/).

Layer Result
structure
vale
ai
render

Four for four. Nicely done.

@ytallo
ytallo merged commit 5266583 into main Aug 20, 2026
64 checks passed
@ytallo
ytallo deleted the feat/e2e-stack-settle branch August 20, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-ticket PR deliberately has no Linear ticket (bump/typo/CI-only)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant