Import open.mp x64 SampSharp code from openmp-sampsharp-x64-poc by Copilot · Pull Request #457 · ikkentim/SampSharp

Copilot · 2026-04-30T13:51:09Z

Agent-Logs-Url: https://github.com/ikkentim/SampSharp/sessions/ab918aa2-7bd5-4b16-a758-55123ff486b2 Co-authored-by: ikkentim <2820647+ikkentim@users.noreply.github.com>

ikkentim · 2026-04-30T14:07:32Z

@copilot instead of copying over the .gitignore, lets instead merge the two.

Agent-Logs-Url: https://github.com/ikkentim/SampSharp/sessions/2298c241-e0c7-4485-8cd8-2ba16faea243 Co-authored-by: ikkentim <2820647+ikkentim@users.noreply.github.com>

Copilot · 2026-04-30T14:08:50Z

@copilot instead of copying over the .gitignore, lets instead merge the two.

Done in d781313. The merged .gitignore keeps the case-insensitive globs ([Bb]in/, [Oo]bj/) and new entries (build_*/, publish/, launchSettings.json) from the open.mp repo, while preserving entries from the original (.idea/, *.suo, *.sln.DotSettings.user, PublishProfiles/, OS files, temp files).

ikkentim

some points from the GH issue have not been addressed.

ikkentim · 2026-04-30T14:08:35Z

@@ -0,0 +1,5 @@
+cmake_minimum_required(VERSION 3.19)


dont have this file in the repo root; we build directly the src/sampsharp-component subdir.

Removed in 033597a. The root CMakeLists.txt is gone; the component is built directly via src/sampsharp-component/build.cmd / build.sh.

ikkentim · 2026-04-30T14:09:04Z

@@ -0,0 +1,91 @@
+<Project>


Rename to Directory.Build.props to match MSBuild docs. (upper case B)

Renamed to Directory.Build.props in 033597a, and updated the SampSharp.sln reference to match.

ikkentim · 2026-04-30T14:10:24Z

@@ -0,0 +1,2 @@
+cmake -S . -B build -A x64 -T ClangCL -DCMAKE_POLICY_VERSION_MINIMUM=3.5


update both build scripts (win/linux) to more closely match the patterns of src/legacy/sampsharp build scripts; it should build like that one to /build; and have publish option to produce artifacts.

also, update the build scripts in to repo root for both the component build and the dotnet build. the scripts in repo root have stubs that need to be implemented (search 'build not yet implemented')

also, update the build and publish workflows, as mentioned in the issue.

Done in 033597a:

src/sampsharp-component/build.cmd and build.sh now follow the legacy patterns (SRCDIR/ROOTDIR/BUILDDIR structure, builds to build/cmake/component/artifacts)

Added src/sampsharp-component/publish.cmd and publish.sh (mirrors legacy publish scripts, copies artifacts to build/artifacts/sampsharp-component/)

Root build.cmd/build.sh: component and component-libraries stubs are fully implemented (delegating to the component scripts)

Workflows component-linux.yml, component-win.yml, and dotnet.yml are updated with real build steps, taking inspiration from the legacy workflows

ikkentim · 2026-04-30T14:14:28Z

@copilot ptal

…ory.Build.props, update build scripts and workflows Agent-Logs-Url: https://github.com/ikkentim/SampSharp/sessions/8b4fc46e-cbf2-47bf-a25f-d5daa919edf9 Co-authored-by: ikkentim <2820647+ikkentim@users.noreply.github.com>

Copilot · 2026-04-30T14:22:24Z

some points from the GH issue have not been addressed.

Addressed in 033597a: hooked up the component build scripts (root build.cmd/build.sh component and component-libraries targets now delegate to src/sampsharp-component/), and updated all three placeholder workflows (component-linux.yml, component-win.yml, dotnet.yml) with real build/publish steps.

ikkentim · 2026-04-30T14:30:42Z

-    echo Component x64 plugin build not yet implemented.
-    goto end
+    if "%ACTION%"=="" (
+        echo Building component x64 plugin...


in the build scripts log lines (both win/linux) call this the 'open.mp component' instead of 'component x64 plugin'

Updated in 30d96bf — all "component x64 plugin" log lines in the root and component build scripts now say "open.mp component".

ikkentim · 2026-04-30T14:31:08Z

-    echo Component C# libraries not yet implemented.
-    goto end
+    if "%ACTION%"=="" (
+        echo Building component C# libraries...


in the build scripts log lines (both win/linux) call this the 'C# libraries' instead of 'component C# libraries

Updated in 30d96bf — "component C# libraries" is now just "C# libraries" in both root build scripts.

ikkentim · 2026-04-30T14:32:34Z

-
-# TODO: Update this workflow when new SampSharp code is in src/sampsharp/
-# For now, this is a placeholder.
+name: CI - Component Libraries


release.yml workflow also needs to be written. can also be much like the release-legacy.yml

Done in 30d96bf — release.yml is now fully implemented following the same pattern as release-legacy.yml: parallel Windows/Linux component builds, a release job that downloads both artifacts and packages them into a zip, creates a GitHub release, then packs and publishes NuGet packages.

Agent-Logs-Url: https://github.com/ikkentim/SampSharp/sessions/cbf76448-ab4a-4fbc-a059-134e175157cb Co-authored-by: ikkentim <2820647+ikkentim@users.noreply.github.com>

ikkentim · 2026-04-30T14:40:34Z

+      - name: Setup .NET
+        uses: actions/setup-dotnet@v4
+        with:
+          dotnet-version: '8.0.x'


dotnet 10 is used

Updated to 10.0.x in 4305294.

ikkentim · 2026-04-30T14:45:00Z

You forgot to also update the naming in the usage section of the scripts

Fixed in 4305294 — the usage sections in both build.cmd and build.sh now use "open.mp component" and "C# libraries".

ikkentim · 2026-04-30T14:45:56Z

+    - name: Setup .NET
+      uses: actions/setup-dotnet@v4
+      with:
+        dotnet-version: '8.0.x'


need .net 10

Updated to 10.0.x in 4305294.

Agent-Logs-Url: https://github.com/ikkentim/SampSharp/sessions/8d2a697e-852b-4b0d-a15a-3b1b77108e8c Co-authored-by: ikkentim <2820647+ikkentim@users.noreply.github.com>

ikkentim

open.mp component build fails on windows

Run .\build.cmd component publish
Building and publishing open.mp component...
Building open.mp component...
Root: D:\a\SampSharp
Build: D:\a\SampSharp\build\cmake\component

CMake Error: The source directory "D:/a/SampSharp/src/sampsharp-component" does not exist.
Specify --help for usage, or press the help button on the CMake GUI.

also, rename the new workflows to match the legacy workflows and the names used in build.cmd

Agent-Logs-Url: https://github.com/ikkentim/SampSharp/sessions/a39a3185-b62b-4fb0-9913-dec6747fa0a7 Co-authored-by: ikkentim <2820647+ikkentim@users.noreply.github.com>

Copilot · 2026-04-30T15:05:38Z

open.mp component build fails on windows
Run .\build.cmd component publish...

Fixed in 7a448cd:

Build failure: src/sampsharp-component/build.cmd and build.sh were going 3 levels up (../../..) to find the repo root, but src/sampsharp-component/ is only 2 levels deep — changed to ../...
Workflow renaming: dotnet.yml → dotnet-component.yml (matching dotnet-legacy.yml), component-win.yml → component-win64.yml (matching plugin-legacy-win32.yml architecture convention).

@copilot ptal

All open items are addressed. Latest commit is 7a448cd.

ikkentim

Linux workflow fails for component

Error: SampSharp.so or SampSharp.dll not found at /home/runner/work/SampSharp/build/cmake/component/artifacts

the build result is probably called sampsharp-component.(dll/so) or something? take a look at cmake files and find out fix

Agent-Logs-Url: https://github.com/ikkentim/SampSharp/sessions/0c492243-e3f4-4744-aef9-bf7e929c89e6 Co-authored-by: ikkentim <2820647+ikkentim@users.noreply.github.com>

Copilot · 2026-04-30T15:19:51Z

Linux workflow fails for component

Error: SampSharp.so or SampSharp.dll not found at /home/runner/work/SampSharp/build/cmake/component/artifacts...

The CMake target produces SampSharp.so / SampSharp.dll (correct names), but publish.sh and publish.cmd had the same 3-levels-up bug as build.sh — causing ROOTDIR to point one level above the repo, so the build artifacts were never found. Fixed in 99ef8ab (changed ../../.. → ../.. in both scripts).

Initial plan

98322ae

Copilot AI assigned Copilot and ikkentim Apr 30, 2026

Copilot started work on behalf of ikkentim April 30, 2026 13:51 View session

Copilot AI linked an issue Apr 30, 2026 that may be closed by this pull request

Import open.mp x64 SampSharp code #456

Closed

Import open.mp x64 SampSharp code from openmp-sampsharp-x64-poc

6f63288

Agent-Logs-Url: https://github.com/ikkentim/SampSharp/sessions/ab918aa2-7bd5-4b16-a758-55123ff486b2 Co-authored-by: ikkentim <2820647+ikkentim@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Import open.mp x64 SampSharp code~~ Import open.mp x64 SampSharp code from openmp-sampsharp-x64-poc Apr 30, 2026

Copilot AI requested a review from ikkentim April 30, 2026 14:07

Copilot finished work on behalf of ikkentim April 30, 2026 14:07

Copilot started work on behalf of ikkentim April 30, 2026 14:07 View session

Merge .gitignore from both repos instead of replacing

d781313

Agent-Logs-Url: https://github.com/ikkentim/SampSharp/sessions/2298c241-e0c7-4485-8cd8-2ba16faea243 Co-authored-by: ikkentim <2820647+ikkentim@users.noreply.github.com>

Copilot finished work on behalf of ikkentim April 30, 2026 14:09

ikkentim reviewed Apr 30, 2026

View reviewed changes

Copilot started work on behalf of ikkentim April 30, 2026 14:14 View session

Copilot finished work on behalf of ikkentim April 30, 2026 14:23

Copilot AI requested a review from ikkentim April 30, 2026 14:23

ikkentim requested changes Apr 30, 2026

View reviewed changes

Copilot started work on behalf of ikkentim April 30, 2026 14:33 View session

ikkentim mentioned this pull request Apr 30, 2026

Merge into main repo SampSharp/openmp-sampsharp-x64-poc#25

Closed

Update log messages and implement release.yml workflow

30d96bf

Agent-Logs-Url: https://github.com/ikkentim/SampSharp/sessions/cbf76448-ab4a-4fbc-a059-134e175157cb Co-authored-by: ikkentim <2820647+ikkentim@users.noreply.github.com>

Copilot finished work on behalf of ikkentim April 30, 2026 14:37

Copilot AI requested a review from ikkentim April 30, 2026 14:37

ikkentim requested changes Apr 30, 2026

View reviewed changes

Copilot started work on behalf of ikkentim April 30, 2026 14:46 View session

Fix usage text naming and update .NET version to 10

4305294

Agent-Logs-Url: https://github.com/ikkentim/SampSharp/sessions/8d2a697e-852b-4b0d-a15a-3b1b77108e8c Co-authored-by: ikkentim <2820647+ikkentim@users.noreply.github.com>

Copilot finished work on behalf of ikkentim April 30, 2026 14:48

Copilot AI requested a review from ikkentim April 30, 2026 14:48

ikkentim requested changes Apr 30, 2026

View reviewed changes

Copilot started work on behalf of ikkentim April 30, 2026 15:01 View session

Fix component build ROOTDIR path and rename CI workflows

7a448cd

Agent-Logs-Url: https://github.com/ikkentim/SampSharp/sessions/a39a3185-b62b-4fb0-9913-dec6747fa0a7 Co-authored-by: ikkentim <2820647+ikkentim@users.noreply.github.com>

Copilot AI requested a review from ikkentim April 30, 2026 15:07

Copilot finished work on behalf of ikkentim April 30, 2026 15:07

ikkentim requested changes Apr 30, 2026

View reviewed changes

Copilot started work on behalf of ikkentim April 30, 2026 15:18 View session

Fix ROOTDIR path in publish.sh and publish.cmd (2 levels up, not 3)

99ef8ab

Agent-Logs-Url: https://github.com/ikkentim/SampSharp/sessions/0c492243-e3f4-4744-aef9-bf7e929c89e6 Co-authored-by: ikkentim <2820647+ikkentim@users.noreply.github.com>

Copilot finished work on behalf of ikkentim April 30, 2026 15:21

Copilot AI requested a review from ikkentim April 30, 2026 15:21

ikkentim approved these changes Apr 30, 2026

View reviewed changes

ikkentim marked this pull request as ready for review April 30, 2026 15:35

ikkentim merged commit d654e55 into master Apr 30, 2026
6 checks passed

ikkentim deleted the copilot/import-openmp-sampsharp-code branch April 30, 2026 21:05

		@@ -0,0 +1,2 @@
		cmake -S . -B build -A x64 -T ClangCL -DCMAKE_POLICY_VERSION_MINIMUM=3.5

Uh oh!

Conversation

Copilot AI commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ikkentim commented Apr 30, 2026

Uh oh!

Copilot AI commented Apr 30, 2026

Uh oh!

ikkentim left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

ikkentim commented Apr 30, 2026

Uh oh!

Copilot AI commented Apr 30, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

ikkentim left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ikkentim left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Apr 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Copilot AI commented Apr 30, 2026 •

edited

Loading

Copilot AI commented Apr 30, 2026 •

edited

Loading