fix(mcping): settings padding, logs label, and single add-server flow - #28
Merged
Conversation
- Hide empty server/log lists so their card's row-gap no longer inflates the bottom padding relative to the top. - Rename the "Log" section to "Logs". - Expand a newly added server's form automatically and disable "Add server" until that server connects or is removed, so only one can be set up at a time. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Mark server name, URL and the API-key header fields as required, and keep the Connect button disabled until they are filled — for API-key auth that means a header name plus a saved secret. The header name pre-fills with the default when API-key auth is selected so the required field is never blank. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The header name already defaults to X-API-Key (placeholder + authDescriptor fallback), so gating Connect on it and pre-filling the input on auth-type change were both unnecessary. Gate API-key auth on the saved secret only. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a few settings-window UI issues.
none/OAuth need only name + URL; the header name keeps itsX-API-Keydefault.)🤖 Generated with Claude Code