Handle some more prefixes - #3
Closed
eileenmcnaughton wants to merge 1 commit into
Closed
Conversation
These lean a bit English but had been submitted to a previous fork
eileenmcnaughton
added a commit
to eileenmcnaughton/name-parser
that referenced
this pull request
Jul 28, 2026
This aligns the English salutations with the ones in the fork after iliaal/nameparser#3 is merged to the fork
eileenmcnaughton
added a commit
to eileenmcnaughton/name-parser
that referenced
this pull request
Jul 28, 2026
This aligns the English salutations with the ones in the fork after iliaal/nameparser#3 is merged to the fork
eileenmcnaughton
added a commit
to eileenmcnaughton/name-parser
that referenced
this pull request
Jul 28, 2026
This aligns the English salutations with the ones in the fork after iliaal/nameparser#3 is merged to the fork
Owner
|
Thanks Eileen. Merged to master, with your commit kept as-is and a follow-up on top. The new keys surfaced two ways a title can eat a name. Both were pre-existing in the mapper and only became reachable once these words were in the dictionary:
The same fix picks up One edit to your dictionary:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These lean a bit English but had been submitted to a previous fork