Fix GH-12171: resolve SimpleXML nodes before equality compare - #222
Closed
iliaal wants to merge 1 commit into
Closed
Fix GH-12171: resolve SimpleXML nodes before equality compare#222iliaal wants to merge 1 commit into
iliaal wants to merge 1 commit into
Conversation
Property proxies like $xml->first store the parent node plus an element iterator name. sxe_objects_compare compared the parent wrappers, so sibling proxies always compared equal. Resolve each side through php_sxe_get_first_node_non_destructive before comparing. Fixes phpGH-12171 Closes phpGH-23187
iliaal
force-pushed
the
fix/gh-12171-sxe-property-compare
branch
from
August 9, 2026 14:33
4d4fd48 to
5a01c95
Compare
Owner
Author
|
Promoted upstream: php#23187 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Property proxies like $xml->first store the parent node plus an element iterator name. sxe_objects_compare compared the parent wrappers, so sibling proxies always compared equal. Resolve each side through php_sxe_get_first_node_non_destructive before comparing.