fix: resolve names inside named-argument values (missing NamedArg resolver arm)#471
Merged
nahime0 merged 3 commits intoJul 7, 2026
Merged
Conversation
…olver arm)
`new self(label: $name, url: new Url('/'))` failed "Undefined class:
Url" — the name resolver's expression walk had no ExprKind::NamedArg
arm, so a named argument's VALUE expression fell through the `_ =>
clone` default and escaped rewriting entirely: any imported alias (or
namespace-relative name) inside it stayed unresolved. Positional
arguments were unaffected, which is why the pattern only surfaced in
named-arg call sites (the ward-component-catalog previews() pattern —
5 survey classes).
Recurse into the value like every other nested-expression arm.
Byte-parity vs PHP 8.5 + codegen regression test (named-arg nested new
of an imported alias). Full suite 6182 passed / 1 env-only failure.
AIC EC-12 (illegalstudio#495).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
(cherry picked from commit 181925e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
new self(label: $name, url: new Url('/'))failed "Undefined class: Url": the name resolver's expression walk had noExprKind::NamedArgarm, so a named argument's VALUE expression fell through the default clone and escaped rewriting entirely — any imported alias (or namespace-relative name) inside it stayed unresolved. Positional arguments were unaffected, which is why it only surfaced at named-arg call sites. Recurse into the value like every other nested-expression arm. Byte-parity vs PHP 8.5 + regression test.