cli: live progress output, comprehensive --help, and --mascotte flag - #615
Merged
Conversation
Camera, MapData, WadFile, WadEntry, and Renderer declared several int/string properties without a type annotation, assigned only in the constructor. The checker inferred those reads as Void|Int instead of Int, which failed a strict int parameter (Game::isBlockingTwoSidedLinedef) and a strict-typed local (Renderer's $thingFloor), the latter cascading into "undefined variable" errors for everything derived from it. Also works around issue #497 (buffer<T> indexing rejects a Mixed index produced by non-constant int arithmetic): cast the loop-counter index to (int) at the one Renderer.php site where it's re-read after a reassign-and-continue branch.
…s always a multiple of 1000 on macOS, pinning the quote to index 0)
They change what kind of program gets built (HTTP server vs. CLI binary, PHP-compatible-only vs. elephc extensions) rather than tweaking codegen output, and are important enough to lead the flag reference instead of being buried in Codegen.
github-actions
Bot
added
area:platform
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
errors/warnings/success output, and a
--timingsreport with per-phase percentages — all gated behind a single "decorated" switch(interactive terminal + not
--quiet), so piped/CI output stays byte-identical to before--quiet/-qflag to force plain output-h/--helpwith a categorized flag reference (Modes, Output modes, Target, Codegen, Linking, Diagnostics,Other); every parameter error now prints a consistent
error: <message>+ usage +--helphint instead of a bare message or adense one-liner
--mascotteeaster egg: prints an ASCII mascot + a random zen/developer quote before any other outputshowcases/doomPHP demo, which didn't compile (untyped class properties inferred asVoid|Int; oneTest plan
cargo buildwarning-freecargo testfilters covering every new module/function (progress, timings, errors::report, cli) all passing--help/-h, every parameter-error path,--quiet,--mascotte(including quote variance acrossruns), plain/piped output byte-compared against pre-branch text (zero ANSI bytes)