Skip to content

[pull] master from python:master#1611

Merged
pull[bot] merged 3 commits intoiloeng:masterfrom
python:master
Dec 25, 2020
Merged

[pull] master from python:master#1611
pull[bot] merged 3 commits intoiloeng:masterfrom
python:master

Conversation

@pull
Copy link
Copy Markdown

@pull pull bot commented Dec 25, 2020

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

ethanfurman and others added 3 commits December 24, 2020 19:31
for multiple inheritance support:

use super().new
pass **kwds to super().new
It was causing CI failures.  the offending file came from #23917

```
python3 tools/rstlint.py ../Misc/NEWS.d/next/
[2] ../Misc/NEWS.d/next/Library/2020-12-23-19-43-06.bpo-42727.WH3ODh.rst:1: default role used
[2] ../Misc/NEWS.d/next/Library/2020-12-23-19-43-06.bpo-42727.WH3ODh.rst:2: default role used
2 problems with severity 2 found.
Makefile:204: recipe for target 'check' failed
```
…23467)

When the modern text= spelling of the universal_newlines= parameter was added
for Python 3.7, check_output's special case around input=None was overlooked.
So it behaved differently with universal_newlines=True vs text=True.  This
reconciles the behavior to be consistent and adds a test to guarantee it.

Also clarifies the existing check_output documentation.

Co-authored-by: Alexey Izbyshev <izbyshev@ispras.ru>
@pull pull bot added the ⤵️ pull label Dec 25, 2020
@pull pull bot merged commit 64abf37 into iloeng:master Dec 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants