feat(dx): add Biome linter/formatter with lint scripts and CI step (#10) - #28
Merged
Conversation
- Add @biomejs/biome v2.5.5 as dev dependency
- Add biome.json configured to match existing code style (single quotes,
semicolons, trailing commas, 2-space indent)
- Remove .prettierrc (Biome replaces Prettier)
- Add lint, lint:fix, format scripts to package.json
- Add pnpm lint step to CI workflow (after typecheck, before test)
- Disable rules that conflict with existing code patterns:
- useImportType, useHookAtTopLevel, useExhaustiveDependencies,
noAssignInExpressions, noStaticOnlyClass, noThisInStatic,
useIterableCallbackReturn
- Set noUnusedImports to warn (genuine issue but not blocking)
- lint script uses biome lint (formatter-only check deferred to format script)
Resolves #10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Biome as the linter/formatter, replacing the
.prettierrcconfig. Configures lint/format scripts and a CI lint step.Changes
.prettierrc(Biome replaces Prettier)biome.json— linter enabled with recommended preset, formatter configured to match existing code style (single quotes, semicolons, trailing commas, 2-space indent, lineWidth 100)package.json:@biomejs/biomev2.5.5 dev dependencylint,lint:fix,formatscripts.github/workflows/ci.yml— addedpnpm lintstep after typecheck, before test.changeset/biome-lint.md— patch bumpDisabled rules (conflict with existing code patterns)
useImportTypeuseHookAtTopLeveluseExhaustiveDependenciesnoAssignInExpressions??=pattern for lazy initializationnoStaticOnlyClassnoThisInStaticuseIterableCallbackReturnforEachwith cleanup-returning callbacks is intentionalorganizeImports(assist)noUnusedImportsis set to warn (genuine issue, not blocking CI).pnpm lintexits 0 on existing source with zero modifications required.Verification
pnpm lint— passes (0 errors, 1 warning)pnpm typecheck— passespnpm test— 57/57 passpnpm build— passesResolves #10
머지 금지 — 사용자 검증 후 머지 지시 예정