build(deps): upgrade okhttp 5.4.0 and spring-boot 4.1.0 (example)#13
Merged
Conversation
Adapt the SDK to the breaking Dependabot major upgrades so they build green. okhttp 4.12.0 -> 5.4.0 (PR #2, #3, #6): - Align the whole okhttp family (okhttp core, okhttp-urlconnection, mockwebserver) to 5.4.0 in the SDK pom and the spring-boot example pom. - Keep the legacy com.squareup.okhttp3:mockwebserver artifact, still published on the 5.x line with the okhttp3.mockwebserver package and the classic MockResponse/MockWebServer API, so no mockwebserver3 rewrite is needed. - okhttp 5 moved JavaNetCookieJar into the okhttp-java-net-cookiejar module (okhttp3.java.net.cookiejar package); the okhttp3.JavaNetCookieJar shim in okhttp-urlconnection compiles but is rejected by javadoc's stricter symbol resolution. Migrate the import in AxiamClient and five test classes to the new canonical package (transitively provided by okhttp-urlconnection). spring-boot 3.5.6 -> 4.1.0 (PR #7): - Bump the spring-boot-app example's parent to 4.1.0, aligning it with the SDK's own spring-boot-starter-security 4.1.0 / spring-test 7.0.8 target. - Spring Boot 4 removed TestRestTemplate; rewrite SpringBootExampleIT to use @LocalServerPort + Spring Framework 7's RestTestClient (servlet stack). Root: mvn -B verify green (191 tests). Example: mvn -B verify green (4 IT). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TWxZaJw6wuMd3d5zqyqdcG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lands the breaking Dependabot bumps that previously failed CI (#2, #3, #6, #7):
okhttp,okhttp-urlconnection,mockwebserver, plus the example's mockwebserver). Kept the classicmockwebservercoordinate/API (no test-body rewrite needed). MigratedJavaNetCookieJarto its newokhttp3.java.net.cookiejarmodule (okhttp 5 moved it out of core) inAxiamClient+ 5 test classes — the old shim compiled under javac but failed the stricter javadoc gate.SpringBootExampleITfrom the removedTestRestTemplateto Spring Framework 7'sRestTestClient(preserves all four IT assertions).Verified locally: root
mvn -B verifygreen (191 tests + JaCoCo + javadoc gate); examplemvn -B verifygreen (4 ITs, full context boot).🤖 Generated with Claude Code
Generated by Claude Code