Improve painter order

[shamilovtim]

Improves the order of painting through the following:

1. rangeAnnotation painting moved outside of the for loop. extraLines removed from the for loop except when extraLinesOnTop is enabled. probably improved performance.
2. the order of painting is revised to background → range annotations → grid → extralines → barLine → dots → (optional): extralines → touchIndicator

[shamilovtim]

good to go

[shamilovtim]

I had one more commit. I needed to paint borders by calling super super paint.

[imaNNeo]

I think I can't push to this PR, because it is in your fork.

[shamilovtim]

that shouldn't be the case. you don't have directions below the merge button that let you push to it?

[imaNNeo]

I think I need permission to push on your forked repo.

[shamilovtim]

I added permissions to my fork but here is what the checkbox says:

[shamilovtim]

I think you might have a duplication:
git push shamilovtim patch-range-annotations the name isn't shamilovtim/patch-range-annotations but only "patch-range-annotations"

[shamilovtim]

also i just noticed that your current branch says 'shamilovtim-patch-range-annotations'. you could try to rename it maybe?

[imaNNeo]

I'm lost :))))

[imaNNeo]

wait for a second

[shamilovtim]

in your terminal you're pushing to my repo named 'shamilovtim' a branch named shamilovtim/patch-range-annotations but your branch is actually named 'shamilovtim-patch-range-annotations' but the real branch name on my repo is only 'patch-range-annotations'

at least i think that's what's going on. i might be wrong. lol

[imaNNeo]

That was a hard work :)

1. I cloned your repo, then I checked out to the patch-range-annotations branch
2. then I added imaNNeoFighT/fl_chart as a new remote (I called itneo)
3. then I ran git fetch neo command
4. cherry-pick that commit from my remote
5. rebase your branch with neo/master
6. force pushed to patch-range-annotations branch

[imaNNeo]

BTW, It's ready to merge in my opinion,
you can have a look at it, and approve my changes to merge.
Thanks!

[shamilovtim]

I haven't tested manually but it looks fine to merge to me