fix(codex): group visual-assistance model picker by provider - #90
Merged
Conversation
The primary picker rendered a group header for every keyed provider, including ones serving no visual model, because only the fallback list filtered empty groups. Both lists now drop them, and both key the group on the provider id instead of its display name, which two providers can share. Grouping also stopped at the dropdowns: the closed trigger and the ordered fallback list still named a selection by its bare model label, so two gateways serving the same model produced identical rows and identical move and remove button names. Both now qualify the label with its provider. Tests cover the empty-provider filter, the fallback picker's grouping, and that picking the second copy of a duplicate label saves that provider's slug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Group primary and fallback visual assistant model options under provider labels so duplicate model ids from different gateways remain distinguishable. Save semantics stay on the existing provider/model slug.
Validation