Skip to content

Demo: Dump button hides perf panel without re-enabling Onyx overlay (user gets stuck) #2

Description

@imedwei

File: demo/src/main/java/com/inksdk/demo/MainActivity.kt:110-113

After a benchmark auto-completes, stopBenchmark shows the perf panel and calls setOverlayEnabled(false). The Dismiss button re-enables the overlay; the Clear button does too. But the Dump button is a plain visibility toggle:

btnDump.setOnClickListener {
    if (perfPanel.visibility == View.VISIBLE) perfPanel.visibility = View.GONE
    else showPerfPanel()
}

If a user taps Dump to hide the panel after a benchmark, the panel disappears but the overlay stays paused — they cannot write again until they figure out to tap Clear.

Suggested fix: route Dump's hide-branch through the same recovery path as Dismiss, or factor a shared hidePerfPanel() that always re-enables the overlay + restores the status text, called from both buttons.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions