Does "Free up storage" consider local/phone or remote/Immich "Favorite" status?

[SimJoSt]

With the announcement of "Free up storage" the following passage was added to the docs:

"Keep favorites: This works the same way Keep albums does. By default, favorited assets are preserved on your device."

As #1669 is not yet implemented, changing the favorite status of a media asset locally after the fact, doesn't reflect the favorite status in Immich. And vice versa.

In the code of the "Free up space" feature (#24999) the following code is used _db.localAssetEntity.isFavorite.equals(false);: https://github.com/immich-app/immich/pull/24999/changes#diff-744f73753b46de7e1bedc351bf1767d4f2ae550ca99157c6fbc5044b1e397e30R166-R168
I just don't know, how the DB works in that case.

[SimJoSt]

It seems like there were some changes made to the code since the introduction of the feature. Now _db.localAssetEntity.isFavorite.equals(false) & _db.remoteAssetEntity.isFavorite.equals(false); is used, seemingly indicating that both the local and the remote favorite status is taken into consideration:

immich/mobile/lib/infrastructure/repositories/local_asset.repository.dart

Lines 186 to 189 in 6e9a425

	if (keepFavorites) {
	whereClause =
	whereClause & _db.localAssetEntity.isFavorite.equals(false) & _db.remoteAssetEntity.isFavorite.equals(false);
	}

Apparently this was introduced with: #26473

While it is great, that both are considered, it would be great if both were also always the same.
Here is hoping #1669 will be implemented soon :)