feat: optionally sync deletes to mobile - #16153
Conversation
bo0tzz
left a comment
bo0tzz
left a comment
There was a problem hiding this comment.
This fully deletes local files when on the server side they've only been moved into the trash so far. I don't think that's the desired behaviour?
…ded to MainActivity kotlin file
|
We'll probably need to restore assets on the mobile device when restored from trash on the web |
|
The other piece of feedback from the maintainers is that this should live behind an option that is disabled by default. To start with it can live under the Advanced heading. In the future, perhaps after it's been battle tested a bit and we have a review screen, it could be moved to Backup |
…diaStore package removed.
…nctionality for local deletion/restoration of media files
danieldietzler
changed the title
| .toList(); | ||
|
|
||
| for (var asset in matchedAssets) { | ||
| FileTrashManager.moveToTrash(asset.fileName); |
There was a problem hiding this comment.
You should create a file repository and move all methods from the FileTrashManager library in there. It helps with mocking the library for testing
| "**/.fvm": true | ||
| } | ||
| } No newline at end of file | ||
| } |
alextran1502
left a comment
alextran1502
left a comment
There was a problem hiding this comment.
Can you please write down in the PR description of how you have tested the PR?
Thanks
|
Closing in favor of the new PR where feedback has been addressed: #16732 |
5 participants
Description
Delete from web and sync to mobile (android)
#3594 (reply in thread)