ci: keep RUSTFLAGS consistent to not rebuild everything

[kkysen]

RUSTFLAGS was being changed only in the cargo test step to link z3. This meant that cargo build was thrown out and redone, making everything take way longer. This moves the z3 addition to RUSTFLAGS to where we install z3 and also only sets it for macOS, where it's needed (for brew).

[ahomescu]

Should we also put -D warnings here?

[kkysen]

They're skipped for the test_translator.py step, although that step doesn't rerun cargo so it doesn't trigger a rebuild. There's an existing comment there explaining why exactly it's skipped there (I forgot off the top of my head).

[ahomescu]

For that step, do we still want the Z3 flags?

[kkysen]

Do we need it? It doesn't hurt, right? For test_translator.py, we specifically don't want -D warnings because the test files inherit that, too, which we didn't want.

[fw-immunant]

Looks like some kind of quoting issue with RUSTFLAGS:

Run export RUSTFLAGS="$RUSTFLAGS -D warnings"
  export RUSTFLAGS="$RUSTFLAGS -D warnings"
  export RUSTDOCFLAGS="-D warnings"
  # Don't build with `--all-features` as `--all-features` includes `--features llvm-static`,
  # which we don't want to test here (see https://github.com/immunant/c2rust/issues/500).
  cargo build --release
  shell: /opt/homebrew/bin/bash -e {0}
  env:
    UV_CACHE_DIR: /Users/runner/work/_temp/setup-uv-cache
    CACHE_ON_FAILURE: false
    CARGO_INCREMENTAL: 0
    Z3_SYS_Z3_HEADER: /opt/homebrew/include/z3.h
    RUSTFLAGS: "-Clink-arg=-L/opt/homebrew/lib -Clink-arg=-Wl,-rpath,/opt/homebrew/lib"
error: failed to run `rustc` to learn about target-specific information

Caused by:
  process didn't exit successfully: `rustc - --crate-name ___ --print=file-names '"-Clink-arg=-L/opt/homebrew/lib' '-Clink-arg=-Wl,-rpath,/opt/homebrew/lib"' -D warnings --crate-type bin --crate-type rlib --crate-type dylib --crate-type cdylib --crate-type staticlib --crate-type proc-macro --print=sysroot --print=cfg` (exit status: 1)
  --- stderr
  error: multiple input filenames provided (first two filenames are `-` and `"-Clink-arg=-L/opt/homebrew/lib`)

[kkysen]

Looks like some kind of quoting issue with RUSTFLAGS:

Run export RUSTFLAGS="$RUSTFLAGS -D warnings"
  export RUSTFLAGS="$RUSTFLAGS -D warnings"
  export RUSTDOCFLAGS="-D warnings"
  # Don't build with `--all-features` as `--all-features` includes `--features llvm-static`,
  # which we don't want to test here (see https://github.com/immunant/c2rust/issues/500).
  cargo build --release
  shell: /opt/homebrew/bin/bash -e {0}
  env:
    UV_CACHE_DIR: /Users/runner/work/_temp/setup-uv-cache
    CACHE_ON_FAILURE: false
    CARGO_INCREMENTAL: 0
    Z3_SYS_Z3_HEADER: /opt/homebrew/include/z3.h
    RUSTFLAGS: "-Clink-arg=-L/opt/homebrew/lib -Clink-arg=-Wl,-rpath,/opt/homebrew/lib"
error: failed to run `rustc` to learn about target-specific information

Caused by:
  process didn't exit successfully: `rustc - --crate-name ___ --print=file-names '"-Clink-arg=-L/opt/homebrew/lib' '-Clink-arg=-Wl,-rpath,/opt/homebrew/lib"' -D warnings --crate-type bin --crate-type rlib --crate-type dylib --crate-type cdylib --crate-type staticlib --crate-type proc-macro --print=sysroot --print=cfg` (exit status: 1)
  --- stderr
  error: multiple input filenames provided (first two filenames are `-` and `"-Clink-arg=-L/opt/homebrew/lib`)

Where do you see that error? I misquoted something initially, but I amended it. Was it that? CI right now looks like it's just failing on the syn v2 thing in c2rust-instrument.

[fw-immunant]

Looks like some kind of quoting issue with RUSTFLAGS:

Where do you see that error? I misquoted something initially, but I amended it. Was it that? CI right now looks like it's just failing on the syn v2 thing in c2rust-instrument.

I see that in the latest macOS CI (https://github.com/immunant/c2rust/actions/runs/18666232932/job/53218050385?pr=1423).

[kkysen]

I see that in the latest macOS CI (https://github.com/immunant/c2rust/actions/runs/18666232932/job/53218050385?pr=1423).

Ah, I was looking at the Linux one. I think I fixed macOS now. It's just running into the existing syn v2 problem.

[fw-immunant]

LGTM.