postprocess: run on a whole dir at once, searching for *.c_decls.json files#1533
Merged
postprocess: run on a whole dir at once, searching for *.c_decls.json files#1533
*.c_decls.json files#1533Conversation
…n` files Previously, we took a root rust source file (like `lib.rs` or `main.rs`). This is because tools like `merge-rust` use that. But the comment transferer works on any `*.rs` file with a corresponding `*.c_decls.json`, so we weren't always giving the rust tools the right root source file. Also, this only worked for running on a single file. Now we take a root source file and search for `*.c_decls.json`s in its directory, passing the root source file to `merge-rust` and the individual `*.rs`s to the comment transferer. This isn't always perfect, as `mod` declarations can reference other files not in the directory hierarchy, but to get that exact search, we'd have to parse the Rust. This should be a good enough approximation for now. Also, this should be better for handling conditional compilation.
thedataking
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we took a root rust source file (like
lib.rsormain.rs). This is because tools likemerge-rustuse that. But the comment transferer works on any*.rsfile with a corresponding*.c_decls.json, so we weren't always giving the rust tools the right root source file. Also, this only worked for running on a single file.Now we take a root source file and search for
*.c_decls.jsons in its directory, passing the root source file tomerge-rustand the individual*.rss to the comment transferer. This isn't always perfect, asmoddeclarations can reference other files not in the directory hierarchy, but to get that exact search, we'd have to parse the Rust. This should be a good enough approximation for now. Also, this should be better for handling conditional compilation.