transpile: Add snapshot tests for wide strings#1631
Merged
kkysen merged 1 commit intoimmunant:masterfrom Mar 3, 2026
Merged
Conversation
Rua
force-pushed
the
wchar-test
branch
2 times, most recently
from
422af07 to
3481632
Compare
kkysen
approved these changes
Mar 3, 2026
Contributor
kkysen
left a comment
kkysen
left a comment
There was a problem hiding this comment.
EDIT: Actually it appears that even Linux and MacOS differ here? Hmm...
A bunch of the type alias names are different. It's annoying.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test is os-specific, because the size of
wchar_tis 2 rather than 4 on Windows. There are no Windows tests (yet) but this way it's prepared for that eventuality. And also makes it clear that portably translating wide strings is still a TODO.EDIT: Actually it appears that even Linux and MacOS differ here? Hmm...