refactor: Also include constructor ids in RenameUnnamed and reorganize_definitions#1744
Open
Rua wants to merge 1 commit intoimmunant:masterfrom
Open
refactor: Also include constructor ids in RenameUnnamed and reorganize_definitions#1744Rua wants to merge 1 commit intoimmunant:masterfrom
RenameUnnamed and reorganize_definitions#1744Rua wants to merge 1 commit intoimmunant:masterfrom
Conversation
Rua
force-pushed
the
refactor-rename-unnamed-ctor
branch
5 times, most recently
from
46569ed to
eb03511
Compare
…nize_definitions`
Rua
force-pushed
the
refactor-rename-unnamed-ctor
branch
from
eb03511 to
891193b
Compare
Rua
changed the title
RenameUnnamed, also include constructor idsRenameUnnamed and reorganize_definitions
ahomescu
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Constructors for tuple/unit structs have a separate ID from their parent item, so they need to be included or calls to those constructors are not renamed. There may be more issues like this in other parts of the refactorer, but these fixes were enough to get #1620 to pass the tests.