fix(build): restore published engines.node to >=20.11.0 - #2934
Merged
Conversation
#2928 raised engines.node from >=20.11.0 to >=24 across the monorepo as a side effect of the dev toolchain upgrade. For published packages that is a breaking change that shipped in a minor (2.24.0): it drops Node 20/22 consumers and makes `npm ci` fail under engine-strict (e.g. Play CI on Node 22). The bundles target es2022, which runs on Node 18+, so the runtime floor does not need Node 24. Restore the consumer-facing floor to >=20.11.0. The repo's dev/build Node (root engines + .nvmrc) intentionally stays at 24.
JCSanPedro
marked this pull request as ready for review
July 29, 2026 04:52
✅ Audience Bundle Size — @imtbl/audience
Budget: 24.00 KB gzipped (warn at 20.00 KB) |
|
View your CI Pipeline Execution ↗ for commit 97d2b06
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
nattb8
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#2928 (dev toolchain upgrade) raised
engines.nodefrom>=20.11.0to>=24across the monorepo, including every published package. For consumers that is a breaking change that shipped in a minor (2.24.0):engine-strictit makesnpm cihard-fail - e.g. Play CI (Node 22) errors withEBADENGINE ... @imtbl/audience@2.24.1 Required: {"node":">=24"}.The bundles target
es2022(verified in eachtsdown.config.js), which runs on Node 18+, so the runtime floor never needed Node 24. This restores the consumer-facing floor to the pre-#2928 value>=20.11.0.Widening
enginesis backward-compatible, so this is safe to release as a patch (2.24.2) - it undoes a breaking change rather than introducing one.Scope
Reverts
engines.nodeto>=20.11.0on the 10 packages #2928 bumped:audience/sdk,audience/sample-app,passport/sdk,config,internal/{toolkit,cryptofiat,dex/sdk,bridge/sdk,generated-clients,metrics}.Intentionally unchanged: the repo's dev/build Node - root
package.jsonenginesand.nvmrc(24.18.0) stay at Node 24, since the upgraded build toolchain (tsdown/pnpm) expects it. Build-time Node and consumer runtime Node are independent.Test plan
2.24.2; confirmnpm view @imtbl/audience@2.24.2 engines={"node":">=20.11.0"}2.24.2;npm cion Node 22 succeeds